Move colorFromPrimitiveValue from StyleResolverState to TextLinkColors

Move colorFromPrimitiveValue from StyleResolverState to TextLinkColors

Break dependencies on state for resolveColorFromPrimitiveValue and move
to TextLinkColors. Also renames it to colorFromPrimitiveValue as it
no longer modifies the state.

This change moves the flag preventing currentColor styles from being
cashed out out StyleResolverState and into RenderStyle where the other
similar flags are located. It also removes the dependency on Element
and RenderStyle by having the caller pass in the current color value.

BUG=259018
TEST=No new tests, covered by existing fast/css tests
R=dglazkov@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153939

[eae, 2013-07-10 19:12:39]

I don't really need to use visitedDependentColor but using color directly (like
we used to do) requires a bunch of new classes being added as friends of
RenderStyle (or the color method being marked as public). I could go either way.

[dglazkov, 2013-07-10 20:07:37]

lgtm

https://codereview.chromium.org/18859010/diff/1/Source/core/dom/TextLinkColors.h
File Source/core/dom/TextLinkColors.h (right):

https://codereview.chromium.org/18859010/diff/1/Source/core/dom/TextLinkColor...
Source/core/dom/TextLinkColors.h:56: Color resolveColorFromPrimitiveValue(const
CSSPrimitiveValue*, Color currentColor, bool forVisitedLink = false) const;
This can just be colorFromPrimitiveValue now. I asked tasak@ to add "resolve" to
hint that we're changing the state of the resolver. But now that you've made it
awesome, the verb is not needed.

[eae, 2013-07-10 20:12:04]

Thanks!

https://codereview.chromium.org/18859010/diff/1/Source/core/dom/TextLinkColors.h
File Source/core/dom/TextLinkColors.h (right):

https://codereview.chromium.org/18859010/diff/1/Source/core/dom/TextLinkColor...
Source/core/dom/TextLinkColors.h:56: Color resolveColorFromPrimitiveValue(const
CSSPrimitiveValue*, Color currentColor, bool forVisitedLink = false) const;
On 2013/07/10 20:07:37, Dimitri Glazkov wrote:
> This can just be colorFromPrimitiveValue now. I asked tasak@ to add "resolve"
to
> hint that we're changing the state of the resolver. But now that you've made
it
> awesome, the verb is not needed.

Makes sense, will rename it.

[commit-bot: I haz the power, 2013-07-10 20:21:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eae@chromium.org/18859010/8001

[commit-bot: I haz the power, 2013-07-10 23:10:11]

Change committed as 153939