Issue 18851002: Cleaning up TODOs in //google_apis.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18851002: Cleaning up TODOs in //google_apis. (Closed)

Created:
7 years, 5 months ago by Jói

Modified:
7 years, 5 months ago

Reviewers:
Finnur

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Cleaning up TODOs in //google_apis. The build warning is no longer necessary as we now have an infobar show up to warn developers if API keys haven't been set. The Python API may never need to be better than it is today, so removing the TODO there; it will be improved if and when needed. The underlying reason for the inconsistent semantics between setting the GOOGLE_DEFAULT_CLIENT_ID/SECRET environment variables and the google_default_client_id/secret gyp variables is gone, so I fixed this mismatch in the current change. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210406

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -36 lines)			Patch
M	google_apis/google_api_keys.cc	View	1 chunk	+0 lines, -16 lines	0 comments	Download
M	google_apis/google_api_keys.py	View	1 chunk	+3 lines, -5 lines	0 comments	Download
M	google_apis/google_apis.gyp	View	1 chunk	+2 lines, -15 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/18851002/1

7 years, 5 months ago (2013-07-08 14:38:17 UTC) #3

Message was sent while issue was closed.

Change committed as 210406

Expand Messages | Collapse Messages