Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: google_apis/google_api_keys.cc

Issue 18851002: Cleaning up TODOs in //google_apis. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | google_apis/google_api_keys.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: google_apis/google_api_keys.cc
diff --git a/google_apis/google_api_keys.cc b/google_apis/google_api_keys.cc
index 034b69a8c3d64c335b5088ae5b995c5c0bf4b29d..fc4b54735b44042eb79c7845028b37020491ac63 100644
--- a/google_apis/google_api_keys.cc
+++ b/google_apis/google_api_keys.cc
@@ -17,22 +17,6 @@
#include "google_apis/internal/google_chrome_api_keys.h"
#endif
-// TODO(joi): Can we enable this warning without having it treated as
-// an error? We don't want to fail builds, just warn, but all warnings
-// from the preprocessor are currently treated as errors, at least in
-// Linux builds.
-#if 0
-#if !defined(GOOGLE_API_KEY) && ( \
- (!defined(GOOGLE_DEFAULT_CLIENT_ID) && \
- !defined(GOOGLE_DEFAULT_CLIENT_SECRET)) \
- || \
- (!defined(GOOGLE_CLIENT_ID_MAIN) && \
- !defined(GOOGLE_CLIENT_SECRET_MAIN)))
-#warning You have not specified API keys; some features may not work.
-#warning See www.chromium.org/developers/how-tos/api-keys for details.
-#endif // (API keys unset)
-#endif // 0
-
// Used to indicate an unset key/id/secret. This works better with
// various unit tests than leaving the token empty.
#define DUMMY_API_TOKEN "dummytoken"
« no previous file with comments | « no previous file | google_apis/google_api_keys.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698