masters/start_master.sh - Issue 1884873010: Fix pid check.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: masters/start_master.sh

Issue 1884873010: Fix pid check. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: masters/start_master.sh

diff --git a/masters/start_master.sh b/masters/start_master.sh

index d6e1d21cbdfb758aeabf6b327e62e22b6adb7961..02ff1ed84245d4a80473fc81ca48155892c9c208 100755

--- a/masters/start_master.sh

+++ b/masters/start_master.sh

@@ -10,13 +10,12 @@ set -e

if [ -f twistd.pid ]; then

PID=`cat twistd.pid`

- if [ -n $(ps -p$PID -o pid=) ]; then

+ if [ -n "$(ps -p$PID -o pid=)" ]; then

echo "twistd.pid has pid $PID which is still alive. aborting."

exit 2

echo 'Now running Buildbot master.'

python $SCRIPTS_DIR/common/twistd --no_save -y buildbot.tac

« no previous file with comments | « no previous file | no next file » | no next file with comments »