Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Side by Side Diff: masters/start_master.sh

Issue 1884873010: Fix pid check. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/bin/sh 1 #!/bin/sh
2 # Copyright (c) 2016 The Chromium Authors. All rights reserved. 2 # Copyright (c) 2016 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 # Starts a master and waits for its pidfile to become live. This was split out 6 # Starts a master and waits for its pidfile to become live. This was split out
7 # of the Makefile in order to make a flock-able unit. 7 # of the Makefile in order to make a flock-able unit.
8 8
9 set -e 9 set -e
10 10
11 if [ -f twistd.pid ]; then 11 if [ -f twistd.pid ]; then
12 PID=`cat twistd.pid` 12 PID=`cat twistd.pid`
13 if [ -n $(ps -p$PID -o pid=) ]; then 13 if [ -n "$(ps -p$PID -o pid=)" ]; then
14 echo "twistd.pid has pid $PID which is still alive. aborting." 14 echo "twistd.pid has pid $PID which is still alive. aborting."
15 exit 2 15 exit 2
16 fi 16 fi
17 fi 17 fi
18 18
19
20 echo 'Now running Buildbot master.' 19 echo 'Now running Buildbot master.'
21 python $SCRIPTS_DIR/common/twistd --no_save -y buildbot.tac 20 python $SCRIPTS_DIR/common/twistd --no_save -y buildbot.tac
22 21
23 echo 'Waiting for creation of twistd.pid...' 22 echo 'Waiting for creation of twistd.pid...'
24 while `test ! -f twistd.pid`; do sleep 1; done; 23 while `test ! -f twistd.pid`; do sleep 1; done;
25 24
26 PID=`cat twistd.pid` 25 PID=`cat twistd.pid`
27 echo "twistd.pid contains new buildbot pid $PID" 26 echo "twistd.pid contains new buildbot pid $PID"
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698