Issue 18820002: Remove ENABLE_LANGUAGE_DETECTION

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18820002: Remove ENABLE_LANGUAGE_DETECTION (Closed)

Created:
7 years, 5 months ago by hajimehoshi

Modified:
7 years, 5 months ago

Reviewers:
Takashi Toyoshima, sky

CC:
chromium-reviews, Miguel Garcia

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

Remove ENABLE_LANGUAGE_DETECTION Now that CLD is used on all platforms, let's remove ENABLE_LANGUAGE_DETECTION. BUG=248454 TEST=unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213361

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -60 lines)			Patch
M	build/common.gypi	View	1	5 chunks	+0 lines, -9 lines	0 comments	Download
M	chrome/browser/chrome_browser_main.cc	View	1	3 chunks	+1 line, -6 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 2	1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome/chrome_common.gypi	View	1	2 chunks	+1 line, -5 lines	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View	1	1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/common/translate/language_detection_util.cc	View	1	8 chunks	+0 lines, -16 lines	0 comments	Download
M	chrome/common/translate/translate_common_metrics.h	View	1	2 chunks	+1 line, -5 lines	0 comments	Download
M	chrome/common/translate/translate_common_metrics.cc	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/common/translate/translate_common_metrics_unittest.cc	View	1	2 chunks	+0 lines, -4 lines	0 comments	Download

Total messages: 5 (0 generated)

hajimehoshi

Can you take a look? Thank you in advance. +sky, I'd like you to look ...

7 years, 5 months ago (2013-07-23 10:34:49 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hajimehoshi@chromium.org/18820002/9010

7 years, 5 months ago (2013-07-24 00:28:39 UTC) #4

Message was sent while issue was closed.

Change committed as 213361