Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6014)

Unified Diff: chrome/common/translate/translate_common_metrics.h

Issue 18820002: Remove ENABLE_LANGUAGE_DETECTION (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Bug fix: mis-rebased Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/translate/translate_common_metrics.h
diff --git a/chrome/common/translate/translate_common_metrics.h b/chrome/common/translate/translate_common_metrics.h
index cfd6b1480d7e033a91885fa4e3f313bf3475212f..0faed7f72f36a1aec003e22a7d13fc07728a198d 100644
--- a/chrome/common/translate/translate_common_metrics.h
+++ b/chrome/common/translate/translate_common_metrics.h
@@ -39,7 +39,7 @@ enum LanguageCheckType {
// When a valid Content-Language is provided, TranslateHelper checks if a
// server provided Content-Language matches to a language CLD determined.
enum LanguageVerificationType {
- LANGUAGE_VERIFICATION_CLD_DISABLED,
+ LANGUAGE_VERIFICATION_CLD_DISABLED, // obsolete
LANGUAGE_VERIFICATION_CLD_ONLY,
LANGUAGE_VERIFICATION_UNKNOWN,
LANGUAGE_VERIFICATION_CLD_AGREE,
@@ -89,13 +89,9 @@ void ReportUserActionDuration(base::TimeTicks begin, base::TimeTicks end);
// Called when a translation is triggered.
void ReportPageScheme(const std::string& scheme);
-#if defined(ENABLE_LANGUAGE_DETECTION)
-
// Called when CLD detects page language.
void ReportLanguageDetectionTime(base::TimeTicks begin, base::TimeTicks end);
-#endif // defined(ENABLE_LANGUAGE_DETECTION)
-
// Called when CLD agreed on a language which is different, but in the similar
// language list.
void ReportSimilarLanguageMatch(bool match);
« no previous file with comments | « chrome/common/translate/language_detection_util.cc ('k') | chrome/common/translate/translate_common_metrics.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698