Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 18789002: Implement Custom Elements' attributeChangedCallback. (Closed)

Created:
7 years, 5 months ago by dominicc (has gone to gerrit)
Modified:
7 years, 5 months ago
Reviewers:
dglazkov
CC:
blink-reviews, Nils Barth (inactive), jsbell+bindings_chromium.org, webcomponents-bugzilla_chromium.org, eae+blinkwatch, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, dominicc+watchlist_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, do-not-use
Visibility:
Public.

Description

Implement Custom Elements' attributeChangedCallback. This is based on the proposal being discussed on this bug: <https://www.w3.org/Bugs/Public/show_bug.cgi?id=22426>; BUG=245518 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153652

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : Sync to tip. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+322 lines, -123 lines) Patch
A LayoutTests/fast/dom/custom/attribute-changed-callback.html View 1 chunk +66 lines, -0 lines 0 comments Download
A + LayoutTests/fast/dom/custom/attribute-changed-callback-expected.txt View 1 chunk +3 lines, -2 lines 0 comments Download
A + LayoutTests/fast/dom/custom/registration-context-delete-during-attribute-changed.html View 1 chunk +5 lines, -8 lines 0 comments Download
A + LayoutTests/fast/dom/custom/registration-context-delete-during-attribute-changed-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/fast/dom/custom/registration-context-delete-during-attribute-changed-retrieval.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + LayoutTests/fast/dom/custom/registration-context-delete-during-attribute-changed-retrieval-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/fast/dom/custom/registration-context-delete-during-callback-recursion.html View 2 chunks +16 lines, -6 lines 0 comments Download
A + LayoutTests/fast/dom/custom/registration-context-delete-during-callback-recursion-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/scripts/CodeGeneratorV8.pm View 3 chunks +3 lines, -5 lines 0 comments Download
M Source/bindings/tests/results/V8TestObject.cpp View 19 chunks +19 lines, -0 lines 0 comments Download
M Source/bindings/v8/CustomElementConstructorBuilder.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/v8/CustomElementConstructorBuilder.cpp View 1 chunk +10 lines, -5 lines 0 comments Download
M Source/bindings/v8/V8CustomElementLifecycleCallbacks.h View 1 chunk +4 lines, -2 lines 0 comments Download
M Source/bindings/v8/V8CustomElementLifecycleCallbacks.cpp View 3 chunks +41 lines, -5 lines 0 comments Download
M Source/bindings/v8/V8HiddenPropertyName.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/v8/custom/V8NodeCustom.cpp View 4 chunks +10 lines, -0 lines 0 comments Download
M Source/core/core.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/dom/ChildNode.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/CustomElementCallbackDispatcher.h View 2 chunks +4 lines, -0 lines 0 comments Download
M Source/core/dom/CustomElementCallbackDispatcher.cpp View 1 3 chunks +42 lines, -6 lines 0 comments Download
A + Source/core/dom/CustomElementCallbackInvocation.h View 1 chunk +17 lines, -7 lines 0 comments Download
A + Source/core/dom/CustomElementCallbackInvocation.cpp View 1 1 chunk +40 lines, -31 lines 0 comments Download
M Source/core/dom/CustomElementCallbackQueue.h View 2 chunks +3 lines, -4 lines 0 comments Download
M Source/core/dom/CustomElementCallbackQueue.cpp View 2 chunks +1 line, -19 lines 0 comments Download
M Source/core/dom/CustomElementLifecycleCallbacks.h View 2 chunks +8 lines, -3 lines 0 comments Download
M Source/core/dom/Element.cpp View 2 chunks +6 lines, -0 lines 0 comments Download
M Source/core/dom/Element.idl View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/dom/NamedNodeMap.idl View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/Node.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/DOMTokenList.idl View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dominicc (has gone to gerrit)
PTAL. Ah, the bindings test results are out of date, hence the patch fails to ...
7 years, 5 months ago (2013-07-05 17:14:30 UTC) #1
dglazkov
lgtm https://codereview.chromium.org/18789002/diff/2001/LayoutTests/fast/dom/custom/attribute-changed-callback.html File LayoutTests/fast/dom/custom/attribute-changed-callback.html (right): https://codereview.chromium.org/18789002/diff/2001/LayoutTests/fast/dom/custom/attribute-changed-callback.html#newcode8 LayoutTests/fast/dom/custom/attribute-changed-callback.html:8: function attributeChanged(_, _, _) { cute!
7 years, 5 months ago (2013-07-06 01:57:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominicc@chromium.org/18789002/8001
7 years, 5 months ago (2013-07-06 04:01:15 UTC) #3
commit-bot: I haz the power
7 years, 5 months ago (2013-07-06 04:30:55 UTC) #4
Message was sent while issue was closed. 
Change committed as 153652

Powered by Google App Engine
This is Rietveld 408576698