Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: chrome/browser/ui/tab_modal_confirm_dialog_browsertest.cc

Issue 18786005: Cleanup: remove redundant tab close observation from TabModalConfirmDialogDelegate (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/tab_modal_confirm_dialog_browsertest.cc
diff --git a/chrome/browser/ui/tab_modal_confirm_dialog_browsertest.cc b/chrome/browser/ui/tab_modal_confirm_dialog_browsertest.cc
index 1ced79b1aed7850b3c1cf1759aeec7a5db1ac14d..b4355bad67064e56b2b36617bfb9f90105d86ccc 100644
--- a/chrome/browser/ui/tab_modal_confirm_dialog_browsertest.cc
+++ b/chrome/browser/ui/tab_modal_confirm_dialog_browsertest.cc
@@ -14,10 +14,8 @@
#include "testing/gtest/include/gtest/gtest.h"
MockTabModalConfirmDialogDelegate::MockTabModalConfirmDialogDelegate(
- content::WebContents* web_contents,
Delegate* delegate)
- : TabModalConfirmDialogDelegate(web_contents),
- delegate_(delegate) {
+ : delegate_(delegate) {
}
MockTabModalConfirmDialogDelegate::~MockTabModalConfirmDialogDelegate() {
@@ -49,8 +47,7 @@ TabModalConfirmDialogTest::TabModalConfirmDialogTest()
}
void TabModalConfirmDialogTest::SetUpOnMainThread() {
- delegate_ = new MockTabModalConfirmDialogDelegate(
- browser()->tab_strip_model()->GetActiveWebContents(), this);
+ delegate_ = new MockTabModalConfirmDialogDelegate(this);
dialog_ = TabModalConfirmDialog::Create(
delegate_, browser()->tab_strip_model()->GetActiveWebContents());
content::RunAllPendingInMessageLoop();
« no previous file with comments | « chrome/browser/ui/tab_modal_confirm_dialog_browsertest.h ('k') | chrome/browser/ui/tab_modal_confirm_dialog_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698