Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 18733007: core/css: Include wtf files using "wtf/foo.h" form. (Closed)

Created:
7 years, 5 months ago by tfarina
Modified:
7 years, 5 months ago
Reviewers:
Nico, abarth-chromium
CC:
blink-reviews, apavlov+blink_chromium.org, dglazkov+blink, eae+blinkwatch, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

core/css: Include wtf files using "wtf/foo.h" form. Instead of including them as: \#include <wtf/foo.h> Change it to include as: \#include "wtf/foo.h" Patch generated with thakis's script: git grep -l '#include <wtf' core/css | xargs sed -i -e 's/#include <\(wtf\/[^>]*\)>/#include "\1"/' BUG=254653 R=thakis@chromium.org,abarth@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154024

Patch Set 1 #

Total comments: 8

Patch Set 2 : review fixes #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -112 lines) Patch
M Source/core/css/BasicShapeFunctions.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSBasicShapes.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/css/CSSBasicShapes.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/css/CSSBorderImageSliceValue.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSBorderImageSliceValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSCalculationValue.h View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/css/CSSCalculationValue.cpp View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M Source/core/css/CSSCanvasValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSCrossfadeValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSCursorImageValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSFontFaceRule.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSFontFaceSource.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSFontFaceSrcValue.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSFontFaceSrcValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSGradientValue.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSGradientValue.cpp View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/css/CSSGrammar.y.includes View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSGroupingRule.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSHelper.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSHostRule.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSImageGeneratorValue.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSImageSetValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSImageValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSImportRule.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSInheritedValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSInheritedValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSInitialValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSInitialValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSLineBoxContainValue.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSOMUtils.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSPrimitiveValueMappings.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/css/CSSPropertySourceData.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/css/CSSRule.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSSelectorList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSStyleDeclaration.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSStyleRule.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSStyleSheet.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSTimingFunctionValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSTimingFunctionValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSUnicodeRangeValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSValueList.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/DOMWindowCSS.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/css/DOMWindowCSS.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/DocumentRuleSets.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/css/FontFeatureValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/FontFeatureValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/FontLoader.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/css/FontValue.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/FontValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/Pair.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/css/PropertySetCSSStyleDeclaration.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/PropertySetCSSStyleDeclaration.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/RGBColor.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/Rect.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/SelectorFilter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/ShadowValue.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/ShadowValue.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/SiblingTraversalStrategies.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/css/StyleMedia.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/StylePropertySerializer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/StylePropertySet.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/css/StyleRule.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/StyleSheetContents.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/StyleSheetList.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/css/StyleSheetList.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
tfarina
Please, have a look. Thanks,
7 years, 5 months ago (2013-07-11 03:13:45 UTC) #1
abarth-chromium
LGTM https://codereview.chromium.org/18733007/diff/1/Source/core/css/CSSBasicShapes.cpp File Source/core/css/CSSBasicShapes.cpp (right): https://codereview.chromium.org/18733007/diff/1/Source/core/css/CSSBasicShapes.cpp#newcode31 Source/core/css/CSSBasicShapes.cpp:31: You can also remove the blank line between ...
7 years, 5 months ago (2013-07-11 03:39:17 UTC) #2
tfarina
https://codereview.chromium.org/18733007/diff/1/Source/core/css/CSSBasicShapes.cpp File Source/core/css/CSSBasicShapes.cpp (right): https://codereview.chromium.org/18733007/diff/1/Source/core/css/CSSBasicShapes.cpp#newcode31 Source/core/css/CSSBasicShapes.cpp:31: On 2013/07/11 03:39:17, abarth wrote: > You can also ...
7 years, 5 months ago (2013-07-11 14:00:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/18733007/7001
7 years, 5 months ago (2013-07-11 14:01:13 UTC) #4
commit-bot: I haz the power
Failed to apply patch for Source/core/css/CSSToStyleMap.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 5 months ago (2013-07-11 14:01:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/18733007/11001
7 years, 5 months ago (2013-07-11 14:03:52 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_python_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=16177
7 years, 5 months ago (2013-07-11 14:32:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/18733007/11001
7 years, 5 months ago (2013-07-11 14:35:50 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_python_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=16183
7 years, 5 months ago (2013-07-11 14:49:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/18733007/11001
7 years, 5 months ago (2013-07-11 16:52:14 UTC) #10
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
7 years, 5 months ago (2013-07-11 16:59:52 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/18733007/11001
7 years, 5 months ago (2013-07-11 17:27:19 UTC) #12
commit-bot: I haz the power
7 years, 5 months ago (2013-07-11 17:28:10 UTC) #13
Message was sent while issue was closed. 
Change committed as 154024

Powered by Google App Engine
This is Rietveld 408576698