Move AutofillMsg_ClearPreviewedForm IPC send to AutofillDriverImpl

Move AutofillMsg_ClearPreviewedForm IPC send to AutofillDriverImpl

Abstracts the implementation of communicating to the renderer that it should
clear a previewed form into the AutofillDriver implementation.

Also performs some test cleanup and renames
AutofillDriver::RendererShouldClearForm() to
AutofillDriver::RendererShouldClearFilledForm() for parallelism.

BUG=247015
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210987

[Ilya Sherman, 2013-07-09 22:45:36]

LGTM

https://codereview.chromium.org/18693005/diff/1/components/autofill/content/b...
File components/autofill/content/browser/autofill_driver_impl_unittest.cc
(right):

https://codereview.chromium.org/18693005/diff/1/components/autofill/content/b...
components/autofill/content/browser/autofill_driver_impl_unittest.cc:130: bool
GetMessageMatchingID(const uint32 messageID) {
nit: Perhaps name this "HasMessageMatchingID" rather than "Get", since only the
boolean return value actually gets used?

https://codereview.chromium.org/18693005/diff/1/components/autofill/content/b...
components/autofill/content/browser/autofill_driver_impl_unittest.cc:130: bool
GetMessageMatchingID(const uint32 messageID) {
nit: For whatever reason, the common style is to not mark parameters as const
unless they're pointers or references.

[blundell, 2013-07-10 08:35:20]

Thanks! Almost done with the sending IPC abstraction...

https://codereview.chromium.org/18693005/diff/1/components/autofill/content/b...
File components/autofill/content/browser/autofill_driver_impl_unittest.cc
(right):

https://codereview.chromium.org/18693005/diff/1/components/autofill/content/b...
components/autofill/content/browser/autofill_driver_impl_unittest.cc:130: bool
GetMessageMatchingID(const uint32 messageID) {
On 2013/07/09 22:45:36, Ilya Sherman wrote:
> nit: Perhaps name this "HasMessageMatchingID" rather than "Get", since only
the
> boolean return value actually gets used?

Done.

https://codereview.chromium.org/18693005/diff/1/components/autofill/content/b...
components/autofill/content/browser/autofill_driver_impl_unittest.cc:130: bool
GetMessageMatchingID(const uint32 messageID) {
On 2013/07/09 22:45:36, Ilya Sherman wrote:
> nit: For whatever reason, the common style is to not mark parameters as const
> unless they're pointers or references.

Done.

[commit-bot: I haz the power, 2013-07-10 08:35:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/blundell@chromium.org/18693005/9001

[commit-bot: I haz the power, 2013-07-10 12:01:01]

Retried try job too often on linux_chromeos for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-07-10 23:29:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/blundell@chromium.org/18693005/9001

[commit-bot: I haz the power, 2013-07-11 00:38:04]

Change committed as 210987