Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 18693005: Move AutofillMsg_ClearPreviewedForm IPC send to AutofillDriverImpl (Closed)

Created:
7 years, 5 months ago by blundell
Modified:
7 years, 5 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, Raman Kakilate, benquan, jam, ahutter, browser-components-watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Dane Wallinga, dyu1, Albert Bodenhamer, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org, sgurun-gerrit only, benm (inactive)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Move AutofillMsg_ClearPreviewedForm IPC send to AutofillDriverImpl Abstracts the implementation of communicating to the renderer that it should clear a previewed form into the AutofillDriver implementation. Also performs some test cleanup and renames AutofillDriver::RendererShouldClearForm() to AutofillDriver::RendererShouldClearFilledForm() for parallelism. BUG=247015 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210987

Patch Set 1 #

Total comments: 4

Patch Set 2 : Response to review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -70 lines) Patch
M components/autofill/content/browser/autofill_driver_impl.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/autofill/content/browser/autofill_driver_impl.cc View 1 chunk +8 lines, -1 line 0 comments Download
M components/autofill/content/browser/autofill_driver_impl_unittest.cc View 1 2 chunks +13 lines, -35 lines 0 comments Download
M components/autofill/core/browser/autofill_driver.h View 1 chunk +5 lines, -2 lines 0 comments Download
M components/autofill/core/browser/autofill_external_delegate.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M components/autofill/core/browser/autofill_external_delegate_unittest.cc View 7 chunks +9 lines, -25 lines 0 comments Download
M components/autofill/core/browser/test_autofill_driver.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/autofill/core/browser/test_autofill_driver.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
blundell
7 years, 5 months ago (2013-07-09 21:46:29 UTC) #1
Ilya Sherman
LGTM https://codereview.chromium.org/18693005/diff/1/components/autofill/content/browser/autofill_driver_impl_unittest.cc File components/autofill/content/browser/autofill_driver_impl_unittest.cc (right): https://codereview.chromium.org/18693005/diff/1/components/autofill/content/browser/autofill_driver_impl_unittest.cc#newcode130 components/autofill/content/browser/autofill_driver_impl_unittest.cc:130: bool GetMessageMatchingID(const uint32 messageID) { nit: Perhaps name ...
7 years, 5 months ago (2013-07-09 22:45:36 UTC) #2
blundell
Thanks! Almost done with the sending IPC abstraction... https://codereview.chromium.org/18693005/diff/1/components/autofill/content/browser/autofill_driver_impl_unittest.cc File components/autofill/content/browser/autofill_driver_impl_unittest.cc (right): https://codereview.chromium.org/18693005/diff/1/components/autofill/content/browser/autofill_driver_impl_unittest.cc#newcode130 components/autofill/content/browser/autofill_driver_impl_unittest.cc:130: bool ...
7 years, 5 months ago (2013-07-10 08:35:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/18693005/9001
7 years, 5 months ago (2013-07-10 08:35:29 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=133713
7 years, 5 months ago (2013-07-10 12:01:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/18693005/9001
7 years, 5 months ago (2013-07-10 23:29:35 UTC) #6
commit-bot: I haz the power
7 years, 5 months ago (2013-07-11 00:38:04 UTC) #7
Message was sent while issue was closed.
Change committed as 210987

Powered by Google App Engine
This is Rietveld 408576698