Pass BrowserContext to drive::MountPointProviderDelegate.

Pass BrowserContext to drive::MountPointProviderDelegate.

As a preparation to get rid of RemoteFileSystemProxy,
let MountPointProviderDelegate take BrowserContext instead of
ExternalMountPoints.
Currently, it is used to take its ExternalMountPoints, but will be used as a
key to take DriveIntegrationService, which manages the drive::FileSystem
instance.
The changes in drive::MountPointProviderDelegate will be done in following CLs.

BUG=253837
TEST=Ran unit_tests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210921

[hidehiko, 2013-07-04 06:37:44]

This CL is based on 18612002, which is LGTM'ed and now in CQ.

The goal of this CL has two goals.
1) Address kinuko@'s review comments in
https://codereview.chromium.org/17644006/. She suggested me to bring
BrowserContext to the GetAdditionalFileSystemMountPointProviders().
2) Prepare to remove RemoteFileSystemProxy in drive::MountPointProviderDelegate.
The context will be used as a key to look up DriveIntegrationService, which is a
BrowserContextKeyedService and will be used for the replacement of
RemoteFileSystemProxy.

Thank you for your review in advance,
- hidehiko

[kinuko, 2013-07-04 06:52:50]

https://codereview.chromium.org/18667002/diff/2001/chrome/browser/chrome_cont...
File chrome/browser/chrome_content_browser_client.h (right):

https://codereview.chromium.org/18667002/diff/2001/chrome/browser/chrome_cont...
chrome/browser/chrome_content_browser_client.h:248: quota::SpecialStoragePolicy*
special_storage_policy,
nit: this one can be also obtained from browser_context.

https://codereview.chromium.org/18667002/diff/2001/content/browser/fileapi/br...
File content/browser/fileapi/browser_file_system_helper.h (right):

https://codereview.chromium.org/18667002/diff/2001/content/browser/fileapi/br...
content/browser/fileapi/browser_file_system_helper.h:33:
quota::SpecialStoragePolicy* special_storage_policy,
nit: this one can be also obtained from browser_context.

[satorux1, 2013-07-04 06:56:12]

chrome/browser/chromeos/drive/ LGTM

[hidehiko, 2013-07-04 07:26:30]

Thank you for your review. PTAL?

https://codereview.chromium.org/18667002/diff/2001/chrome/browser/chrome_cont...
File chrome/browser/chrome_content_browser_client.h (right):

https://codereview.chromium.org/18667002/diff/2001/chrome/browser/chrome_cont...
chrome/browser/chrome_content_browser_client.h:248: quota::SpecialStoragePolicy*
special_storage_policy,
On 2013/07/04 06:52:50, kinuko wrote:
> nit: this one can be also obtained from browser_context.

Done.

https://codereview.chromium.org/18667002/diff/2001/content/browser/fileapi/br...
File content/browser/fileapi/browser_file_system_helper.h (right):

https://codereview.chromium.org/18667002/diff/2001/content/browser/fileapi/br...
content/browser/fileapi/browser_file_system_helper.h:33:
quota::SpecialStoragePolicy* special_storage_policy,
On 2013/07/04 06:52:50, kinuko wrote:
> nit: this one can be also obtained from browser_context.

Done.

[kinuko, 2013-07-04 07:34:53]

lgtm

https://codereview.chromium.org/18667002/diff/12002/content/public/browser/co...
File content/public/browser/content_browser_client.h (right):

https://codereview.chromium.org/18667002/diff/12002/content/public/browser/co...
content/public/browser/content_browser_client.h:561: // |browser_context| and
|special_storage_policy| are needed in the
nit: please remove |special_storage_policy|

[kinaba, 2013-07-04 07:43:11]

One more LGTM for c/b/cros/drive

[hidehiko, 2013-07-04 14:51:30]

Thank you for your review.

Avi, could you also take a look?

Thanks,
- hidehiko

https://codereview.chromium.org/18667002/diff/12002/content/public/browser/co...
File content/public/browser/content_browser_client.h (right):

https://codereview.chromium.org/18667002/diff/12002/content/public/browser/co...
content/public/browser/content_browser_client.h:561: // |browser_context| and
|special_storage_policy| are needed in the
On 2013/07/04 07:34:54, kinuko wrote:
> nit: please remove |special_storage_policy|

Done.

[hidehiko, 2013-07-09 04:45:39]

Hello Joi,

Could you kindly review this CL (content/public/browser/... part) as an OWNER?
(Avi seems to be OOO...)

Thank you for your review in advance,
- hidehiko

[hidehiko, 2013-07-10 15:06:28]

Hello, Jói.
Friendly ping? Could you kindly take a look?

Thanks,
- hidehiko

[Jói, 2013-07-10 15:10:41]

LGTM, sorry for missing this yesterday.

[hidehiko, 2013-07-10 15:12:18]

On 2013/07/10 15:10:41, Jói wrote:
> LGTM, sorry for missing this yesterday.

Thank you for your quick reply!
Sending to CQ.
- hidehiko

[commit-bot: I haz the power, 2013-07-10 15:12:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hidehiko@chromium.org/18667002/27001

[commit-bot: I haz the power, 2013-07-10 15:24:00]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[hidehiko, 2013-07-10 16:26:02]

Hello Charlie,
Could you kindly review
 content/browser/storage_partition_impl.cc as an OWNER?

Thank you for your help in advance,
- hidehiko

[Charlie Reis, 2013-07-10 17:35:51]

LGTM.  We're hoping to avoid adding dependencies on BrowserContext within most
of StoragePartition, but this is during creation, so Albert and I don't think
it's a problem.

[hidehiko, 2013-07-10 17:41:14]

On 2013/07/10 17:35:51, creis wrote:
> LGTM.  We're hoping to avoid adding dependencies on BrowserContext within most
> of StoragePartition, but this is during creation, so Albert and I don't think
> it's a problem.

Thank you for your quick review.

Sending to CQ.
- hidehiko

[commit-bot: I haz the power, 2013-07-10 17:41:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hidehiko@chromium.org/18667002/27001

[commit-bot: I haz the power, 2013-07-10 20:35:33]

Change committed as 210921