Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1866213002: [DevTools] Move inspect from Inspector to Runtime. (Closed)

Created:
4 years, 8 months ago by dgozman
Modified:
4 years, 8 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, jam, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, blink-reviews, apavlov+blink_chromium.org, sergeyv+blink_chromium.org, kinuko+watch, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@inspector-connection
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Move inspect from Inspector to Runtime. BUG=none Committed: https://crrev.com/52d969af3c83c19eda3d08d9a66a14388de25bb3 Cr-Commit-Position: refs/heads/master@{#385868}

Patch Set 1 #

Total comments: 2

Patch Set 2 : inspectRequested #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -237 lines) Patch
M content/browser/devtools/protocol/inspector_handler.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/devtools/protocol/inspector_handler.cc View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/command-line-api-inspect.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/agents-enable-disable.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/agents-enable-disable-expected.txt View 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-console/debugger-command-line-api.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/Source/core/inspector/InspectorInspectorAgent.h View 1 chunk +0 lines, -66 lines 0 comments Download
D third_party/WebKit/Source/core/inspector/InspectorInspectorAgent.cpp View 1 chunk +0 lines, -73 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 1 chunk +0 lines, -36 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js View 1 2 chunks +44 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/protocol.json View 1 2 chunks +11 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScriptHost.h View 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScriptHost.cpp View 4 chunks +9 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h View 1 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp View 1 2 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8RuntimeAgent.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp View 3 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
dgozman
Take a look please.
4 years, 8 months ago (2016-04-07 00:23:02 UTC) #2
pfeldman
lgtm https://codereview.chromium.org/1866213002/diff/1/third_party/WebKit/Source/devtools/protocol.json File third_party/WebKit/Source/devtools/protocol.json (right): https://codereview.chromium.org/1866213002/diff/1/third_party/WebKit/Source/devtools/protocol.json#newcode1044 third_party/WebKit/Source/devtools/protocol.json:1044: "name": "inspect", inspectRequested
4 years, 8 months ago (2016-04-07 01:33:01 UTC) #3
dgozman
https://codereview.chromium.org/1866213002/diff/1/third_party/WebKit/Source/devtools/protocol.json File third_party/WebKit/Source/devtools/protocol.json (right): https://codereview.chromium.org/1866213002/diff/1/third_party/WebKit/Source/devtools/protocol.json#newcode1044 third_party/WebKit/Source/devtools/protocol.json:1044: "name": "inspect", On 2016/04/07 01:33:01, pfeldman wrote: > inspectRequested ...
4 years, 8 months ago (2016-04-07 18:30:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1866213002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1866213002/20001
4 years, 8 months ago (2016-04-07 18:31:02 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-07 21:26:14 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 21:30:05 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/52d969af3c83c19eda3d08d9a66a14388de25bb3
Cr-Commit-Position: refs/heads/master@{#385868}

Powered by Google App Engine
This is Rietveld 408576698