Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1865553003: vm-service: Answer fields from superclass to subclass in declaration order (layout order). (Closed)

Created:
4 years, 8 months ago by rmacnak
Modified:
4 years, 8 months ago
Reviewers:
turnidge
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

vm-service: Answer fields from superclass to subclass in declaration order (layout order). BUG=http://dartbug.com/26160 R=turnidge@google.com Committed: https://github.com/dart-lang/sdk/commit/441f7d852405547309173e401fe41391218c4ec0

Patch Set 1 #

Total comments: 2

Patch Set 2 : reverse abc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -10 lines) Patch
A runtime/observatory/tests/service/instance_field_order_rpc_test.dart View 1 1 chunk +54 lines, -0 lines 0 comments Download
M runtime/vm/object_service.cc View 1 chunk +17 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
rmacnak
4 years, 8 months ago (2016-04-05 21:21:37 UTC) #2
turnidge
lgtm https://chromiumcodereview.appspot.com/1865553003/diff/1/runtime/observatory/tests/service/instance_field_order_rpc_test.dart File runtime/observatory/tests/service/instance_field_order_rpc_test.dart (right): https://chromiumcodereview.appspot.com/1865553003/diff/1/runtime/observatory/tests/service/instance_field_order_rpc_test.dart#newcode15 runtime/observatory/tests/service/instance_field_order_rpc_test.dart:15: var b = 2; Maybe reverse a and ...
4 years, 8 months ago (2016-04-18 22:48:03 UTC) #3
rmacnak
https://chromiumcodereview.appspot.com/1865553003/diff/1/runtime/observatory/tests/service/instance_field_order_rpc_test.dart File runtime/observatory/tests/service/instance_field_order_rpc_test.dart (right): https://chromiumcodereview.appspot.com/1865553003/diff/1/runtime/observatory/tests/service/instance_field_order_rpc_test.dart#newcode15 runtime/observatory/tests/service/instance_field_order_rpc_test.dart:15: var b = 2; On 2016/04/18 22:48:03, turnidge wrote: ...
4 years, 8 months ago (2016-04-18 23:07:59 UTC) #4
rmacnak
4 years, 8 months ago (2016-04-18 23:14:23 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
441f7d852405547309173e401fe41391218c4ec0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698