Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: common/api/logdog_coordinator/services/v1/service.proto

Issue 1863973002: LogDog: Update to archival V2. (Closed) Base URL: https://github.com/luci/luci-go@grpcutil-errors
Patch Set: Code review comments, use Pub/Sub, archival staging, quality of life. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: common/api/logdog_coordinator/services/v1/service.proto
diff --git a/common/api/logdog_coordinator/services/v1/service.proto b/common/api/logdog_coordinator/services/v1/service.proto
index db1ef88b07954b804fcf935ac7874548aea11f2e..d26d8081def0276e56323de99f0728d13623acf9 100644
--- a/common/api/logdog_coordinator/services/v1/service.proto
+++ b/common/api/logdog_coordinator/services/v1/service.proto
@@ -8,6 +8,7 @@ package logdog;
import "state.proto";
import "github.com/luci/luci-go/common/proto/logdog/logpb/log.proto";
+import "google/protobuf/duration.proto";
import "google/protobuf/empty.proto";
// GetConfigResponse is the response structure for the user
@@ -68,6 +69,13 @@ message LoadStreamResponse {
// If requested, the serialized log stream descriptor. The protobuf version
// of this descriptor will match the "proto_version" field in "state".
bytes desc = 2;
+
+ // The age of the log stream.
+ google.protobuf.Duration age = 3;
+
+ // The archival key of the log stream. If this key doesn't match the key in
+ // the archival request, the request is superfluous and should be deleted.
+ bytes archival_key = 4;
}
// TerminateStreamRequest is the set of caller-supplied data for the
@@ -87,11 +95,16 @@ message TerminateStreamRequest {
message ArchiveStreamRequest {
// The path of the log stream that was archived.
string path = 1;
- // If true, the archive includes the full set of log stream entries between
- // [0..terminal_index].
- bool complete = 2;
+ // The number of log entries that were archived.
+ int64 log_entry_count = 2;
// The highest log stream index that was archived.
int64 terminal_index = 3;
+ // If not empty, there was an archival error.
+ //
+ // This field serves to indivate that an error occured (being non-empty) and
iannucci 2016/04/19 00:55:28 indicate?
dnj 2016/04/20 18:15:10 indubitably.
+ // to supply an value that will show up in the Coordinator ArchiveStream
+ // endpoint logs.
+ string error = 4;
// The archive URL of the log stream's stream data.
string stream_url = 10;

Powered by Google App Engine
This is Rietveld 408576698