LogDog: Update to archival V2.

common/api/logdog_coordinator/services/v1/service.proto

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 syntax = "proto3";
 
 package logdog;
 
 import "state.proto";
 import "github.com/luci/luci-go/common/proto/logdog/logpb/log.proto";
+import "google/protobuf/duration.proto";
 import "google/protobuf/empty.proto";
 
 // GetConfigResponse is the response structure for the user
 // "GetConfig" endpoint.
 message GetConfigResponse {
   // The API URL of the base "luci-config" service. If empty, the default
   // service URL will be used.
   string config_service_url = 1;
 
   // The name of the configuration set to load from.
@@ skipping 40 matching lines @@
 }
 
 // The response message for the LoadStream RPC.
 message LoadStreamResponse {
   // The state of the requested log stream.
   LogStreamState state = 1;
 
   // If requested, the serialized log stream descriptor. The protobuf version
   // of this descriptor will match the "proto_version" field in "state".
   bytes desc = 2;
+
+  // The age of the log stream.
+  google.protobuf.Duration age = 3;
+
+  // The archival key of the log stream. If this key doesn't match the key in
+  // the archival request, the request is superfluous and should be deleted.
+  bytes archival_key = 4;
 }
 
 // TerminateStreamRequest is the set of caller-supplied data for the
 // TerminateStream service endpoint.
 message TerminateStreamRequest {
   // The log stream's path.
   string path = 1;
   // The log stream's secret.
   bytes secret = 2;
 
   // The terminal index of the stream.
   int64 terminal_index = 3;
 }
 
 // ArchiveStreamRequest is the set of caller-supplied data for the ArchiveStream
 // service endpoint.
 message ArchiveStreamRequest {
   // The path of the log stream that was archived.
   string path = 1;
-  // If true, the archive includes the full set of log stream entries between
-  // [0..terminal_index].
-  bool complete = 2;
+  // The number of log entries that were archived.
+  int64 log_entry_count = 2;
   // The highest log stream index that was archived.
   int64 terminal_index = 3;
+  // If not empty, there was an archival error.
+  //
+  // This field serves to indivate that an error occured (being non-empty) and

[iannucci, 2016/04/19 00:55:28]

indicate?

[dnj, 2016/04/20 18:15:10]

indubitably.

+  // to supply an value that will show up in the Coordinator ArchiveStream
+  // endpoint logs.
+  string error = 4;
 
   // The archive URL of the log stream's stream data.
   string stream_url = 10;
   // The size of the log stream's stream data.
   int64 stream_size = 11;
 
   // The archive URL of the log stream's index data.
   string index_url = 20;
   // The size of the log stream's index data.
   int64 index_size = 21;
@@ skipping 19 matching lines @@
 
   // TerminateStream is an idempotent operation to update the stream's terminal
   // index.
   rpc TerminateStream(TerminateStreamRequest) returns (google.protobuf.Empty);
 
   // ArchiveStream is an idempotent operation to record a log stream's archival
   // parameters. It is used by the Archivist service upon successful stream
   // archival.
   rpc ArchiveStream(ArchiveStreamRequest) returns (google.protobuf.Empty);
 }