third_party/WebKit/Source/core/svg/graphics/SVGImage.h - Issue 1857543002: Don't recreate SkImages for high-res (GIF, WEBP...) animations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/graphics/SVGImage.h

Issue 1857543002: Don't recreate SkImages for high-res (GIF, WEBP...) animations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review #4 fix. Thanks @pkasting. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/ImageQualityControllerTest.cpp ('k') | third_party/WebKit/Source/core/svg/graphics/SVGImageForContainer.h » ('j') | third_party/WebKit/Source/platform/graphics/BitmapImageTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/svg/graphics/SVGImage.h

diff --git a/third_party/WebKit/Source/core/svg/graphics/SVGImage.h b/third_party/WebKit/Source/core/svg/graphics/SVGImage.h

index 5adc7a4cb562fbfa107c06c22972f1ca4785f903..9c586eaf8929d3f1488cd42f92eb8a1a95275055 100644

--- a/third_party/WebKit/Source/core/svg/graphics/SVGImage.h

+++ b/third_party/WebKit/Source/core/svg/graphics/SVGImage.h

@@ -99,7 +99,7 @@ private:

// FIXME: SVGImages are underreporting decoded sizes and will be unable

// to prune because these functions are not implemented yet.

- void destroyDecodedData(bool) override { }

+ void destroyDecodedData() override { }

// FIXME: Implement this to be less conservative.

bool currentFrameKnownToBeOpaque(MetadataMode = UseCurrentMetadata) override { return false; }