Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: third_party/WebKit/Source/core/svg/graphics/SVGImage.h

Issue 1857543002: Don't recreate SkImages for high-res (GIF, WEBP...) animations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review #4 fix. Thanks @pkasting. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006 Eric Seidel <eric@webkit.org> 2 * Copyright (C) 2006 Eric Seidel <eric@webkit.org>
3 * Copyright (C) 2009 Apple Inc. All rights reserved. 3 * Copyright (C) 2009 Apple Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
92 92
93 String filenameExtension() const override; 93 String filenameExtension() const override;
94 94
95 IntSize containerSize() const; 95 IntSize containerSize() const;
96 bool usesContainerSize() const override { return true; } 96 bool usesContainerSize() const override { return true; }
97 97
98 bool dataChanged(bool allDataReceived) override; 98 bool dataChanged(bool allDataReceived) override;
99 99
100 // FIXME: SVGImages are underreporting decoded sizes and will be unable 100 // FIXME: SVGImages are underreporting decoded sizes and will be unable
101 // to prune because these functions are not implemented yet. 101 // to prune because these functions are not implemented yet.
102 void destroyDecodedData(bool) override { } 102 void destroyDecodedData() override { }
103 103
104 // FIXME: Implement this to be less conservative. 104 // FIXME: Implement this to be less conservative.
105 bool currentFrameKnownToBeOpaque(MetadataMode = UseCurrentMetadata) override { return false; } 105 bool currentFrameKnownToBeOpaque(MetadataMode = UseCurrentMetadata) override { return false; }
106 106
107 SVGImage(ImageObserver*); 107 SVGImage(ImageObserver*);
108 void draw(SkCanvas*, const SkPaint&, const FloatRect& fromRect, const FloatR ect& toRect, RespectImageOrientationEnum, ImageClampingMode) override; 108 void draw(SkCanvas*, const SkPaint&, const FloatRect& fromRect, const FloatR ect& toRect, RespectImageOrientationEnum, ImageClampingMode) override;
109 void drawForContainer(SkCanvas*, const SkPaint&, const FloatSize, float, con st FloatRect&, const FloatRect&, const KURL&); 109 void drawForContainer(SkCanvas*, const SkPaint&, const FloatSize, float, con st FloatRect&, const FloatRect&, const KURL&);
110 void drawPatternForContainer(GraphicsContext&, const FloatSize, float, const FloatRect&, const FloatSize&, const FloatPoint&, 110 void drawPatternForContainer(GraphicsContext&, const FloatSize, float, const FloatRect&, const FloatSize&, const FloatPoint&,
111 SkXfermode::Mode, const FloatRect&, const FloatSize& repeatSpacing, cons t KURL&); 111 SkXfermode::Mode, const FloatRect&, const FloatSize& repeatSpacing, cons t KURL&);
112 PassRefPtr<SkImage> imageForCurrentFrameForContainer(const KURL&, const Floa tSize& containerSize); 112 PassRefPtr<SkImage> imageForCurrentFrameForContainer(const KURL&, const Floa tSize& containerSize);
(...skipping 30 matching lines...) Expand all
143 m_image->setImageObserver(m_observer); 143 m_image->setImageObserver(m_observer);
144 } 144 }
145 private: 145 private:
146 Image* m_image; 146 Image* m_image;
147 RawPtrWillBeMember<ImageObserver> m_observer; 147 RawPtrWillBeMember<ImageObserver> m_observer;
148 }; 148 };
149 149
150 } // namespace blink 150 } // namespace blink
151 151
152 #endif // SVGImage_h 152 #endif // SVGImage_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698