Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1856273002: Change all FlakyTest import to use org.chromium.base.test.util.FlakyTest (Closed)

Created:
4 years, 8 months ago by Yoland Yan(Google)
Modified:
4 years, 8 months ago
CC:
bondd+autofillwatch_chromium.org, browser-components-watch_chromium.org, cbentzel+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, estade+watch_chromium.org, jam, jdonnelly+autofillwatch_chromium.org, maxbogue+watch_chromium.org, plaree+watch_chromium.org, rouslan+autofill_chromium.org, tim+watch_chromium.org, vabr+watchlistautofill_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change all FlakyTest import to use org.chromium.base.test.util.FlakyTest BUG= Committed: https://crrev.com/c4f7db8464349b98b0c75f098b73b9eeaa863bf0 Cr-Commit-Position: refs/heads/master@{#387937}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Change @FlakyTest bug message #

Patch Set 3 : Change @FlakyTest bug message #

Total comments: 1

Patch Set 4 : Forgot change content shell javatest FlakyTest import #

Patch Set 5 : #

Patch Set 6 : Gn target #

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -105 lines) Patch
M base/BUILD.gn View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/AudioTest.java View 1 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/ContentViewFocusTest.java View 1 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/PowerBroadcastReceiverTest.java View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/PrerenderTest.java View 1 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/TabsOpenedFromExternalAppTest.java View 1 4 chunks +3 lines, -5 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/TabsTest.java View 1 7 chunks +6 lines, -11 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillKeyboardAccessoryTest.java View 1 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/compositor/overlays/strip/TabStripTest.java View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java View 2 chunks +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/document/DocumentModeTest.java View 1 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/ntp/interests/InterestsServiceTest.java View 1 5 chunks +5 lines, -8 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxTest.java View 1 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/UndoTabModelTest.java View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/video/FullscreenVideoTest.java View 1 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/test/ParametersOnMultiTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/test/util/ChromeSigninUtilsTest.java View 1 5 chunks +5 lines, -9 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/test/util/parameters/SigninParametersTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/OpenTabsTest.java View 1 3 chunks +3 lines, -5 lines 0 comments Download
M chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java View 1 4 chunks +3 lines, -5 lines 0 comments Download
M chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/ui/PassphraseTypeDialogFragmentTest.java View 1 2 chunks +2 lines, -3 lines 0 comments Download
M components/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/CronetSampleTest.java View 1 2 chunks +2 lines, -3 lines 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java View 1 2 3 4 3 chunks +3 lines, -5 lines 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java View 1 2 chunks +2 lines, -3 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java View 1 2 3 9 chunks +9 lines, -17 lines 0 comments Download

Messages

Total messages: 28 (11 generated)
Yoland Yan(Google)
4 years, 8 months ago (2016-04-05 02:52:25 UTC) #2
jbudorick
Where is @FlakyTest...? Also, when you do this conversion, please move any relevant comments into ...
4 years, 8 months ago (2016-04-05 13:22:25 UTC) #3
Yoland Yan(Google)
https://codereview.chromium.org/1856273002/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/AudioTest.java File chrome/android/javatests/src/org/chromium/chrome/browser/AudioTest.java (right): https://codereview.chromium.org/1856273002/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/AudioTest.java#newcode49 chrome/android/javatests/src/org/chromium/chrome/browser/AudioTest.java:49: @FlakyTest On 2016/04/05 13:22:25, jbudorick wrote: > e.g., add ...
4 years, 8 months ago (2016-04-06 18:17:20 UTC) #5
mikecase (-- gone --)
non-owner lgtm
4 years, 8 months ago (2016-04-07 18:03:46 UTC) #6
jbudorick
also non-owner lgtm
4 years, 8 months ago (2016-04-07 18:11:03 UTC) #7
chromium-reviews
Damn On Thu, Apr 7, 2016, 11:11 <jbudorick@chromium.org> wrote: > also non-owner lgtm > > ...
4 years, 8 months ago (2016-04-07 18:14:20 UTC) #8
Yoland Yan(Google)
For detail about the change, please check this thread: https://groups.google.com/a/google.com/forum/#!topic/clank-team/jG_A_kAhilo
4 years, 8 months ago (2016-04-08 00:08:22 UTC) #10
gone
lgtm https://chromiumcodereview.appspot.com/1856273002/diff/40001/chrome/android/javatests/src/org/chromium/chrome/browser/TabsOpenedFromExternalAppTest.java File chrome/android/javatests/src/org/chromium/chrome/browser/TabsOpenedFromExternalAppTest.java (right): https://chromiumcodereview.appspot.com/1856273002/diff/40001/chrome/android/javatests/src/org/chromium/chrome/browser/TabsOpenedFromExternalAppTest.java#newcode502 chrome/android/javatests/src/org/chromium/chrome/browser/TabsOpenedFromExternalAppTest.java:502: @FlakyTest(message = "http://crbug.com/6467101") This is a buganizer bug.
4 years, 8 months ago (2016-04-08 00:16:18 UTC) #11
xunjieli
cronet/* lgtm. You mentioned in your email that flaky tests can be tracked in some ...
4 years, 8 months ago (2016-04-08 14:06:01 UTC) #12
Yoland Yan(Google)
On 2016/04/08 14:06:01, xunjieli wrote: > cronet/* lgtm. You mentioned in your email that flaky ...
4 years, 8 months ago (2016-04-08 20:35:51 UTC) #13
no sievers
content lgtm
4 years, 8 months ago (2016-04-11 17:26:44 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1856273002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1856273002/40001
4 years, 8 months ago (2016-04-11 23:25:11 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_dbg/builds/49070) android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED, ...
4 years, 8 months ago (2016-04-11 23:43:52 UTC) #18
danakj
LGTM do you need gyp too?
4 years, 8 months ago (2016-04-13 23:55:57 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1856273002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1856273002/120001
4 years, 8 months ago (2016-04-18 16:28:51 UTC) #24
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 8 months ago (2016-04-18 17:25:26 UTC) #26
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 17:26:45 UTC) #28
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/c4f7db8464349b98b0c75f098b73b9eeaa863bf0
Cr-Commit-Position: refs/heads/master@{#387937}

Powered by Google App Engine
This is Rietveld 408576698