Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java

Issue 1856273002: Change all FlakyTest import to use org.chromium.base.test.util.FlakyTest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java
diff --git a/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java b/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java
index 31ea2d929b7aad9bcea89a8d8d92495f7565b580..60316efe96da2db2f42ff256435ff4f525f5cf7b 100644
--- a/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java
+++ b/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java
@@ -6,7 +6,6 @@ package org.chromium.chrome.browser.sync;
import android.accounts.Account;
import android.app.Activity;
-import android.test.FlakyTest;
import android.test.suitebuilder.annotation.LargeTest;
import org.chromium.base.ActivityState;
@@ -14,6 +13,7 @@ import org.chromium.base.ApplicationStatus;
import org.chromium.base.ThreadUtils;
import org.chromium.base.test.util.DisabledTest;
import org.chromium.base.test.util.Feature;
+import org.chromium.base.test.util.FlakyTest;
import org.chromium.chrome.browser.ChromeActivity;
import org.chromium.chrome.browser.signin.AccountIdProvider;
import org.chromium.chrome.browser.signin.AccountTrackerService;
@@ -67,9 +67,8 @@ public class SyncTest extends SyncTestBase {
* @FlakyTest
* @LargeTest
* @Feature({"Sync"})
- * BUG = crbug.com/588050, crbug.com/595893
*/
- @DisabledTest
+ @DisabledTest(message = "crbug.com/588050,crbug.com/595893")
public void testRename() throws InterruptedException {
// The two accounts object that would represent the account rename.
final Account oldAccount = setUpTestAccountAndSignInToSync();
@@ -130,9 +129,8 @@ public class SyncTest extends SyncTestBase {
/*
* @LargeTest
* @Feature({"Sync"})
- * BUG = crbug.com/594558
*/
- @FlakyTest
+ @FlakyTest(message = "crbug.com/594558")
public void testStopAndStartSyncThroughAndroid() throws InterruptedException {
Account account = setUpTestAccountAndSignInToSync();
SyncTestUtil.waitForSyncActive();

Powered by Google App Engine
This is Rietveld 408576698