Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 18555005: Move importer messages to common (Closed)

Created:
7 years, 5 months ago by scottmg
Modified:
7 years, 5 months ago
Reviewers:
jschuh, sky
CC:
chromium-reviews, dbeam+watch-options_chromium.org, chromium-apps-reviews_chromium.org, robertshield, tfarina, extensions-reviews_chromium.org
Visibility:
Public.

Description

Move importer messages to common Goal is moving profile_import_process_messages to chrome/common so they can be used to communicate between the utility and browser. This also requires moving some of the simple structs/enums that are used in messages. (a few gypi updates that got missed in previous CLs too) TBR=jschuh@chromium.org R=sky@chromium.org BUG=254672 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209828

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -673 lines) Patch
M chrome/browser/automation/automation_provider_observers.h View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/bookmarks/bookmarks_api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/first_run/first_run.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/bookmarks_file_importer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/external_process_importer_bridge.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/importer/external_process_importer_client.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/external_process_importer_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/external_process_importer_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/firefox_importer_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/importer/ie_importer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/ie_importer_browsertest_win.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/importer/importer_bridge.h View 1 chunk +1 line, -1 line 0 comments Download
A chrome/browser/importer/importer_creator.h View 1 chunk +28 lines, -0 lines 0 comments Download
A + chrome/browser/importer/importer_creator.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/importer/importer_data_types.h View 1 chunk +0 lines, -56 lines 0 comments Download
D chrome/browser/importer/importer_data_types.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M chrome/browser/importer/importer_host.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/importer_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/importer_list.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/importer_progress_observer.h View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/importer/importer_type.h View 1 chunk +0 lines, -46 lines 0 comments Download
D chrome/browser/importer/importer_type.cc View 1 chunk +0 lines, -107 lines 0 comments Download
D chrome/browser/importer/profile_import_process_messages.h View 1 chunk +0 lines, -294 lines 0 comments Download
D chrome/browser/importer/profile_import_process_messages.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M chrome/browser/ui/webui/options/import_data_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/import_data_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 5 chunks +2 lines, -10 lines 0 comments Download
M chrome/chrome_common.gypi View 1 chunk +10 lines, -1 line 0 comments Download
M chrome/common/all_messages.h View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/common/importer/importer_data_types.h View 1 chunk +56 lines, -56 lines 0 comments Download
A + chrome/common/importer/importer_data_types.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/common/importer/importer_type.h View 2 chunks +5 lines, -18 lines 0 comments Download
A + chrome/common/importer/profile_import_process_messages.h View 2 chunks +4 lines, -5 lines 0 comments Download
A + chrome/common/importer/profile_import_process_messages.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/utility/profile_import_handler.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
scottmg
7 years, 5 months ago (2013-07-02 20:57:55 UTC) #1
sky
LGTM
7 years, 5 months ago (2013-07-02 21:03:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/18555005/1
7 years, 5 months ago (2013-07-02 21:07:20 UTC) #3
scottmg
tbr jschuh for _messages renames.
7 years, 5 months ago (2013-07-02 21:11:41 UTC) #4
jschuh
innocuous file rename/move. ipc security lgtm.
7 years, 5 months ago (2013-07-02 21:12:40 UTC) #5
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
7 years, 5 months ago (2013-07-03 00:21:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/18555005/1
7 years, 5 months ago (2013-07-03 00:30:45 UTC) #7
commit-bot: I haz the power
7 years, 5 months ago (2013-07-03 00:32:15 UTC) #8
Message was sent while issue was closed. 
Change committed as 209828

Powered by Google App Engine
This is Rietveld 408576698