Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1151)

Unified Diff: chrome/browser/importer/importer_type.cc

Issue 18555005: Move importer messages to common (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/importer/importer_type.h ('k') | chrome/browser/importer/profile_import_process_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/importer/importer_type.cc
diff --git a/chrome/browser/importer/importer_type.cc b/chrome/browser/importer/importer_type.cc
deleted file mode 100644
index be1254326d669b04496036c7cceabfbe0a6d5413..0000000000000000000000000000000000000000
--- a/chrome/browser/importer/importer_type.cc
+++ /dev/null
@@ -1,107 +0,0 @@
-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "chrome/browser/importer/importer_type.h"
-
-#include "base/logging.h"
-#include "base/metrics/histogram.h"
-#include "chrome/browser/importer/bookmarks_file_importer.h"
-#include "chrome/browser/importer/firefox3_importer.h"
-
-#if defined(OS_WIN)
-#include "chrome/browser/importer/ie_importer.h"
-#endif
-
-#if defined(OS_MACOSX)
-#include <CoreFoundation/CoreFoundation.h>
-#include "base/mac/foundation_util.h"
-#include "chrome/browser/importer/safari_importer.h"
-#endif
-
-namespace importer {
-
-namespace {
-
-// The enum used to register importer use.
-enum ImporterTypeMetrics {
- IMPORTER_METRICS_UNKNOWN = 0,
-#if defined(OS_WIN)
- IMPORTER_METRICS_IE = 1,
-#endif
- IMPORTER_METRICS_FIREFOX2 = 2, // obsolete
- IMPORTER_METRICS_FIREFOX3 = 3,
-#if defined(OS_MACOSX)
- IMPORTER_METRICS_SAFARI = 4,
-#endif
- IMPORTER_METRICS_GOOGLE_TOOLBAR5 = 5, // obsolete
- IMPORTER_METRICS_BOOKMARKS_FILE = 6,
-
- // Insert new values here. Never remove any existing values, as this enum is
- // used to bucket a UMA histogram, and removing values breaks that.
- IMPORTER_METRICS_SIZE
-};
-
-
-} // namespace
-
-Importer* CreateImporterByType(ImporterType type) {
- switch (type) {
-#if defined(OS_WIN)
- case TYPE_IE:
- return new IEImporter();
-#endif
- case TYPE_BOOKMARKS_FILE:
- return new BookmarksFileImporter();
- case TYPE_FIREFOX3:
- return new Firefox3Importer();
-#if defined(OS_MACOSX)
- case TYPE_SAFARI:
- return new SafariImporter(base::mac::GetUserLibraryPath());
-#endif
- default:
- NOTREACHED();
- return NULL;
- }
- NOTREACHED();
- return NULL;
-}
-
-void LogImporterUseToMetrics(const std::string& metric_postfix,
- ImporterType type) {
- ImporterTypeMetrics metrics_type = IMPORTER_METRICS_UNKNOWN;
- switch (type) {
- case TYPE_UNKNOWN:
- metrics_type = IMPORTER_METRICS_UNKNOWN;
- break;
-#if defined(OS_WIN)
- case TYPE_IE:
- metrics_type = IMPORTER_METRICS_IE;
- break;
-#endif
- case TYPE_FIREFOX3:
- metrics_type = IMPORTER_METRICS_FIREFOX3;
- break;
-#if defined(OS_MACOSX)
- case TYPE_SAFARI:
- metrics_type = IMPORTER_METRICS_SAFARI;
- break;
-#endif
- case TYPE_BOOKMARKS_FILE:
- metrics_type = IMPORTER_METRICS_BOOKMARKS_FILE;
- break;
- }
-
- // Note: This leaks memory, which is the expected behavior as the factory
- // creates and owns the histogram.
- base::HistogramBase* histogram =
- base::LinearHistogram::FactoryGet(
- "Import.ImporterType." + metric_postfix,
- 1,
- IMPORTER_METRICS_SIZE,
- IMPORTER_METRICS_SIZE + 1,
- base::HistogramBase::kUmaTargetedHistogramFlag);
- histogram->Add(metrics_type);
-}
-
-} // namespace importer
« no previous file with comments | « chrome/browser/importer/importer_type.h ('k') | chrome/browser/importer/profile_import_process_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698