Fix unhandled showGuessPanel editor command

Fix unhandled showGuessPanel editor command

The main menu sends a -showGuessPanel: to first responder when
Edit -> Spelling and Grammar -> Show Spelling and Grammar is called.

showGuessPanel was supposed to be handled by RenderWidgetHostViewMacDelegate,
it should be forwarded to the delegate from RenderWidgetHostViewMac by
-forwardingTargetForSelector:. However, since we dynamically added
implementations for all editing commands, including showGuessPanel, to
RenderWidgetHostViewMac via RenderWidgetHostViewMacEditCommandHelper,
RenderWidgetHostViewMacDelegate didn't get to handle this command at all,
it's directly sent to WebFrameImpl::executeCommand(name, "").

Add missing handling there (previously only WebFrameImpl::executeCommand()
with command name but not value is handled) so that showGuessPanel is
correctly handled.

BUG=257627
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158346

[commit-bot: I haz the power, 2013-07-06 09:50:29]

No comments yet.

[Jiang Jiang, 2013-07-10 19:17:27]

Eric, I added you as reviewer because you seemed to be the last one who touched
the code. This seemed to be a Mac specific issue so if you think anyone else
might be more appropriate to review it please forward it.

The code seemed to be from WebKit and never changed much since.

[Jiang Jiang, 2013-07-19 15:20:34]

On 2013/07/10 19:17:27, Jiang wrote:
> Eric, I added you as reviewer because you seemed to be the last one who
touched
> the code. This seemed to be a Mac specific issue so if you think anyone else
> might be more appropriate to review it please forward it.
> 
> The code seemed to be from WebKit and never changed much since.

eseidel: ping

[eseidel, 2013-09-25 19:36:49]

lgtm

[commit-bot: I haz the power, 2013-09-25 19:37:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jiangj@opera.com/18553006/1

[commit-bot: I haz the power, 2013-09-25 19:37:03]

Failed to apply patch for Source/WebKit/chromium/src/WebFrameImpl.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  A         Source/WebKit
  Created missing directory Source/WebKit.
  A         Source/WebKit/chromium
  Created missing directory Source/WebKit/chromium.
  A         Source/WebKit/chromium/src
  Created missing directory Source/WebKit/chromium/src.
  can't find file to patch at input line 6
  Perhaps you used the wrong -p or --strip option?
  The text leading up to this was:
  --------------------------
  |Index: Source/WebKit/chromium/src/WebFrameImpl.cpp
  |diff --git a/Source/WebKit/chromium/src/WebFrameImpl.cpp
b/Source/WebKit/chromium/src/WebFrameImpl.cpp
  |index
573b8977887ebc3aecef7cdaf8d91636b3239218..f4d39568ba7d1b54b2e2def77f6b1318726119b2
100644
  |--- a/Source/WebKit/chromium/src/WebFrameImpl.cpp
  |+++ b/Source/WebKit/chromium/src/WebFrameImpl.cpp
  --------------------------
  No file to patch.  Skipping patch.
  1 out of 1 hunk ignored

Patch:       Source/WebKit/chromium/src/WebFrameImpl.cpp
Index: Source/WebKit/chromium/src/WebFrameImpl.cpp
diff --git a/Source/WebKit/chromium/src/WebFrameImpl.cpp
b/Source/WebKit/chromium/src/WebFrameImpl.cpp
index
573b8977887ebc3aecef7cdaf8d91636b3239218..f4d39568ba7d1b54b2e2def77f6b1318726119b2
100644
--- a/Source/WebKit/chromium/src/WebFrameImpl.cpp
+++ b/Source/WebKit/chromium/src/WebFrameImpl.cpp
@@ -1232,6 +1232,11 @@ bool WebFrameImpl::executeCommand(const WebString& name,
const WebString& value,
     if (!frame()->editor()->canEdit() && webName == "moveToEndOfDocument")
         return viewImpl()->propagateScroll(ScrollDown, ScrollByDocument);
 
+    if (webName == "showGuessPanel") {
+        frame()->editor()->showSpellingGuessPanel();
+        return true;
+    }
+
     return frame()->editor()->command(webName).execute(value);
 }

[commit-bot: I haz the power, 2013-09-25 20:23:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jiangj@opera.com/18553006/8001

[commit-bot: I haz the power, 2013-09-26 01:19:23]

Change committed as 158346