Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Side by Side Diff: Source/web/WebFrameImpl.cpp

Issue 18553006: Fix unhandled showGuessPanel editor command (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 1175 matching lines...) Expand 10 before | Expand all | Expand 10 after
1186 if (pluginContainer && pluginContainer->executeEditCommand(name, value)) 1186 if (pluginContainer && pluginContainer->executeEditCommand(name, value))
1187 return true; 1187 return true;
1188 1188
1189 // moveToBeginningOfDocument and moveToEndfDocument are only handled by WebK it for editable nodes. 1189 // moveToBeginningOfDocument and moveToEndfDocument are only handled by WebK it for editable nodes.
1190 if (!frame()->editor().canEdit() && webName == "moveToBeginningOfDocument") 1190 if (!frame()->editor().canEdit() && webName == "moveToBeginningOfDocument")
1191 return viewImpl()->propagateScroll(ScrollUp, ScrollByDocument); 1191 return viewImpl()->propagateScroll(ScrollUp, ScrollByDocument);
1192 1192
1193 if (!frame()->editor().canEdit() && webName == "moveToEndOfDocument") 1193 if (!frame()->editor().canEdit() && webName == "moveToEndOfDocument")
1194 return viewImpl()->propagateScroll(ScrollDown, ScrollByDocument); 1194 return viewImpl()->propagateScroll(ScrollDown, ScrollByDocument);
1195 1195
1196 if (webName == "showGuessPanel") {
1197 frame()->editor().showSpellingGuessPanel();
1198 return true;
1199 }
1200
1196 return frame()->editor().command(webName).execute(value); 1201 return frame()->editor().command(webName).execute(value);
1197 } 1202 }
1198 1203
1199 bool WebFrameImpl::isCommandEnabled(const WebString& name) const 1204 bool WebFrameImpl::isCommandEnabled(const WebString& name) const
1200 { 1205 {
1201 ASSERT(frame()); 1206 ASSERT(frame());
1202 return frame()->editor().command(name).isEnabled(); 1207 return frame()->editor().command(name).isEnabled();
1203 } 1208 }
1204 1209
1205 void WebFrameImpl::enableContinuousSpellChecking(bool enable) 1210 void WebFrameImpl::enableContinuousSpellChecking(bool enable)
(...skipping 1258 matching lines...) Expand 10 before | Expand all | Expand 10 after
2464 2469
2465 // There is a possibility that the frame being detached was the only 2470 // There is a possibility that the frame being detached was the only
2466 // pending one. We need to make sure final replies can be sent. 2471 // pending one. We need to make sure final replies can be sent.
2467 flushCurrentScopingEffort(m_findRequestIdentifier); 2472 flushCurrentScopingEffort(m_findRequestIdentifier);
2468 2473
2469 cancelPendingScopingEffort(); 2474 cancelPendingScopingEffort();
2470 } 2475 }
2471 } 2476 }
2472 2477
2473 } // namespace WebKit 2478 } // namespace WebKit
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698