Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 18522003: Remove unnecessary host parameter in forwarder. (Closed)

Created:
7 years, 5 months ago by Philippe
Modified:
7 years, 5 months ago
Reviewers:
bulach, frankf
CC:
chromium-reviews, craigdh+watch_chromium.org, kkania, frankf, chrome-speed-team+watch_google.com, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, telemetry+watch_chromium.org, frankf+watch_chromium.org, hartmanng
Visibility:
Public.

Description

Remove unnecessary host parameter in forwarder. While it is nice to be able to specify the destination host when setting up a redirection, this functionality is never used. This cleanup is needed for some upcoming changes in forwarder2. BUG=242846 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209756

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -14 lines) Patch
M build/android/adb_reverse_forwarder.py View 2 chunks +1 line, -4 lines 0 comments Download
M build/android/pylib/base/base_test_runner.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/chrome_test_server_spawner.py View 1 chunk +1 line, -2 lines 0 comments Download
M build/android/pylib/forwarder.py View 3 chunks +2 lines, -3 lines 0 comments Download
M build/android/pylib/instrumentation/test_runner.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/run_py_tests.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/test_environment.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/chrome/adb_commands.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Philippe
7 years, 5 months ago (2013-07-02 12:00:21 UTC) #1
bulach
lgtm, thanks!
7 years, 5 months ago (2013-07-02 12:03:53 UTC) #2
nduca
should hartmanng review this?
7 years, 5 months ago (2013-07-02 16:31:42 UTC) #3
bulach
sure, +hartmanng as FYI :) this is changing just the android implementation of forwarder2, no ...
7 years, 5 months ago (2013-07-02 16:34:28 UTC) #4
Philippe
On 2013/07/02 16:31:42, nduca wrote: > should hartmanng review this? In my opinion Marcus' review ...
7 years, 5 months ago (2013-07-02 16:36:14 UTC) #5
nduca
Oh, beg your pardon. I read the patch wrong :)
7 years, 5 months ago (2013-07-02 16:43:00 UTC) #6
frankf
lgtm
7 years, 5 months ago (2013-07-02 17:08:20 UTC) #7
Philippe
On 2013/07/02 17:08:20, frankf wrote: > lgtm Thanks guys!
7 years, 5 months ago (2013-07-02 17:16:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pliard@chromium.org/18522003/1001
7 years, 5 months ago (2013-07-02 17:16:59 UTC) #9
commit-bot: I haz the power
7 years, 5 months ago (2013-07-02 19:50:29 UTC) #10
Message was sent while issue was closed.
Change committed as 209756

Powered by Google App Engine
This is Rietveld 408576698