Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Unified Diff: build/android/pylib/forwarder.py

Issue 18522003: Remove unnecessary host parameter in forwarder. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/pylib/forwarder.py
diff --git a/build/android/pylib/forwarder.py b/build/android/pylib/forwarder.py
index 965823ee4dace1d0e3a33e64ecb95220771e9d24..40a5d36fae3305753d68b6bffc46cfb97bc2b355 100644
--- a/build/android/pylib/forwarder.py
+++ b/build/android/pylib/forwarder.py
@@ -53,7 +53,7 @@ class Forwarder(object):
self._device_forwarder_path_on_host = os.path.join(
cmd_helper.OutDirectory.get(), build_type, 'forwarder_dist')
- def Run(self, port_pairs, tool, host_name):
+ def Run(self, port_pairs, tool):
"""Runs the forwarder.
Args:
@@ -64,8 +64,6 @@ class Forwarder(object):
DevicePortForHostPort method.
tool: Tool class to use to get wrapper, if necessary, for executing the
forwarder (see valgrind_tools.py).
- host_name: Address to forward to, must be addressable from the
- host machine. Usually use loopback '127.0.0.1'.
Raises:
Exception on failure to forward the port.
@@ -73,6 +71,7 @@ class Forwarder(object):
with self._lock:
self._InitDeviceLocked(tool)
self._InitHostLocked()
+ host_name = '127.0.0.1'
redirection_commands = [
'%d:%d:%d:%s' % (self._host_adb_control_port, device, host,
host_name) for device, host in port_pairs]
« no previous file with comments | « build/android/pylib/chrome_test_server_spawner.py ('k') | build/android/pylib/instrumentation/test_runner.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698