Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 18516009: [Android WebView] Fix downstream mac builds. (Closed)

Created:
7 years, 5 months ago by benm (inactive)
Modified:
7 years, 5 months ago
CC:
chromium-reviews, shashi
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[Android WebView] Fix downstream mac builds. The downstream mac builders don't understand --warn-shared-textrel so disable it for android_webview builds. BUG=157326 TBR=torne@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210032

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M build/common.gypi View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
benm (inactive)
7 years, 5 months ago (2013-07-03 19:47:12 UTC) #1
benm (inactive)
ptal
7 years, 5 months ago (2013-07-03 19:47:25 UTC) #2
Kristian Monsen
lgtm
7 years, 5 months ago (2013-07-03 19:48:33 UTC) #3
benm (inactive)
+joth!
7 years, 5 months ago (2013-07-03 19:50:48 UTC) #4
joth
lgtm
7 years, 5 months ago (2013-07-03 19:51:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benm@chromium.org/18516009/1
7 years, 5 months ago (2013-07-03 20:00:04 UTC) #6
commit-bot: I haz the power
7 years, 5 months ago (2013-07-03 20:05:30 UTC) #7
Message was sent while issue was closed.
Change committed as 210032

Powered by Google App Engine
This is Rietveld 408576698