Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: build/common.gypi

Issue 18516009: [Android WebView] Fix downstream mac builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index a61e7c703f9d0f403c363c25a6d4ab2c76088e71..72dd1f84c3075f5805858be1420813ebb4c93b9a 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -2773,8 +2773,10 @@
}],
['OS=="android" and android_webview_build==1', {
'ldflags!': [
- # Must not turn on --fatal-warnings, see crbug.com/157326.
+ # Must not turn on --fatal-warnings or warn-shared-textrel,
+ # see crbug.com/157326.
'-Wl,--fatal-warnings',
+ '-Wl,--warn-shared-textrel',
],
}],
['OS=="android" and android_full_debug==0', {
@@ -2852,8 +2854,10 @@
}],
['OS=="android" and android_webview_build==1', {
'ldflags!': [
- # Must not turn on --fatal-warnings, see crbug.com/157326.
+ # Must not turn on --fatal-warnings or
+ # shared-text-rel, see crbug.com/157326.
'-Wl,--fatal-warnings',
+ '-Wl,--warn-shared-textrel',
],
}],
['clang==1', {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698