Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Issue 18512011: core/html: Include wtf files using "wtf/foo.h" form. (Closed)

Created:
7 years, 5 months ago by tfarina
Modified:
7 years, 5 months ago
Reviewers:
Nico, abarth-chromium
CC:
blink-reviews, eae+blinkwatch, kinuko, feature-media-reviews_chromium.org, dglazkov+blink, Rik, adamk+blink_chromium.org, aandrey+blink_chromium.org, vcarbune.chromium
Visibility:
Public.

Description

core/html: Include wtf files using "wtf/foo.h" form. Instead of including them as: \#include <wtf/foo.h> Change it to include as: \#include "wtf/foo.h" Patch generated with thakis's script: git grep -l '#include <wtf' Source/core/editing | xargs sed -i -e 's/#include <\(wtf\/[^>]*\)>/#include "\1"/' This also covers fileapi and history, since both are tiny. BUG=254653 R=thakis@chromium.org,abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154184

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -191 lines) Patch
M Source/core/fileapi/File.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/fileapi/FileList.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/fileapi/FileReader.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/fileapi/FileReader.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/fileapi/FileReaderLoader.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/fileapi/FileReaderSync.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/history/BackForwardClient.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/history/BackForwardController.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/BaseMultipleFieldsDateAndTimeInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/ButtonInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/CheckboxInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/DOMFormData.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/DOMTokenList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/DateInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/EmailInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/FileInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/FileInputType.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/FormAssociatedElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/FormController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLAnchorElement.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLButtonElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLCanvasElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLFieldSetElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFontElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFormControlElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFormElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLKeygenElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLNameCollection.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLOptGroupElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLPlugInElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLQuoteElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLSelectElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTextAreaElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTextFormControlElement.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HiddenInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/ImageData.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/ImageInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/InputType.cpp View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/InputTypeNames.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/LabelsNodeList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/MediaController.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/MediaControllerInterface.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/MediaFragmentURIParser.cpp View 1 1 chunk +3 lines, -4 lines 0 comments Download
M Source/core/html/MediaKeyEvent.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/html/MonthInputType.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/html/RadioInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/ResetInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/SearchInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/StepRange.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/SubmitInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/TelephoneInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/TextInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/TimeInputType.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/html/TypeAhead.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/URLInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/ValidityState.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/VoidCallback.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/WeekInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/CanvasContextAttributes.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/CanvasPathMethods.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/CanvasPattern.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/CanvasStyle.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/canvas/CanvasStyle.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/WebGLContextGroup.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/canvas/WebGLGetInfo.h View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/core/html/canvas/WebGLGetInfo.cpp View 1 2 chunks +4 lines, -5 lines 0 comments Download
M Source/core/html/parser/AtomicHTMLToken.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/parser/BackgroundHTMLInputStream.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/parser/CSSPreloadScanner.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/CompactHTMLToken.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/parser/HTMLElementStack.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/HTMLEntityParser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/HTMLEntitySearch.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/HTMLEntityTable.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/HTMLFormattingElementList.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/parser/HTMLIdentifier.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/HTMLIdentifier.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/parser/HTMLPreloadScanner.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/HTMLScriptRunner.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/parser/HTMLScriptRunnerHost.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/HTMLSourceTracker.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/html/parser/HTMLStackItem.h View 1 1 chunk +3 lines, -4 lines 0 comments Download
M Source/core/html/parser/HTMLToken.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/parser/InputStreamPreprocessor.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/NestingLevelIncrementer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/ClearButtonElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/DateTimeFieldElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/DateTimeFieldElements.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/shadow/DateTimeNumericFieldElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/DateTimeSymbolicFieldElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/shadow/DetailsMarkerControl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/HTMLShadowElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/MeterShadowElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/ProgressShadowElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/TextControlInnerElements.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/track/InbandTextTrack.cpp View 1 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/html/track/TextTrackRegion.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/track/TextTrackRegion.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/track/TextTrackRegionList.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/track/TrackBase.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/track/WebVTTParser.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/track/WebVTTParser.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/html/track/WebVTTTokenizer.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
tfarina
7 years, 5 months ago (2013-07-14 02:41:03 UTC) #1
abarth-chromium
rs=me LGTM
7 years, 5 months ago (2013-07-14 02:43:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/18512011/108
7 years, 5 months ago (2013-07-14 02:46:07 UTC) #3
commit-bot: I haz the power
Failed to apply patch for Source/core/html/PasswordInputType.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 5 months ago (2013-07-14 02:46:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/18512011/6001
7 years, 5 months ago (2013-07-14 03:09:37 UTC) #5
commit-bot: I haz the power
7 years, 5 months ago (2013-07-14 04:41:27 UTC) #6
Message was sent while issue was closed.
Change committed as 154184

Powered by Google App Engine
This is Rietveld 408576698