Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 1849613002: Remove the Data Reduction Proxy SSL Android code (Closed)

Created:
4 years, 8 months ago by megjablon
Modified:
4 years, 8 months ago
Reviewers:
bengr, newt (away)
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the Data Reduction Proxy SSL Android code The SSL experiment is over so remove the SSL snackbar and preferences code. BUG=593068 Committed: https://crrev.com/bd4c6ac99e771e0d5893b25d8058d3153efb6fa1 Cr-Commit-Position: refs/heads/master@{#384732}

Patch Set 1 #

Total comments: 2

Messages

Total messages: 10 (3 generated)
megjablon
bengr: chrome/browser/* newt: chrome/android/*
4 years, 8 months ago (2016-03-31 22:28:32 UTC) #2
newt (away)
lgtm
4 years, 8 months ago (2016-04-01 00:31:59 UTC) #3
bengr
Is this everything? LGTM. https://codereview.chromium.org/1849613002/diff/1/chrome/android/java/strings/android_chrome_strings.grd File chrome/android/java/strings/android_chrome_strings.grd (left): https://codereview.chromium.org/1849613002/diff/1/chrome/android/java/strings/android_chrome_strings.grd#oldcode787 chrome/android/java/strings/android_chrome_strings.grd:787: <!-- Intentionally empty. This is ...
4 years, 8 months ago (2016-04-01 17:31:18 UTC) #4
megjablon
This is all the Android code. I'm going to send out a separate CL for ...
4 years, 8 months ago (2016-04-01 18:48:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1849613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1849613002/1
4 years, 8 months ago (2016-04-01 23:04:51 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-01 23:56:59 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 23:57:58 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bd4c6ac99e771e0d5893b25d8058d3153efb6fa1
Cr-Commit-Position: refs/heads/master@{#384732}

Powered by Google App Engine
This is Rietveld 408576698