Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1847063003: Show the close all incognito notification for tabbed mode. (Closed)

Created:
4 years, 8 months ago by Ted C
Modified:
4 years, 8 months ago
Reviewers:
gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Show the close all incognito notification for tabbed mode. BUG=597147 Committed: https://crrev.com/0a2547bf57fc79635eace4f935275a67b2b79d52 Cr-Commit-Position: refs/heads/master@{#384764}

Patch Set 1 #

Patch Set 2 : Check null for file info #

Total comments: 4

Patch Set 3 : dfalcantara comments #

Patch Set 4 : findbugs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -94 lines) Patch
M chrome/android/java/AndroidManifest.xml View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java View 1 2 3 chunks +0 lines, -25 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/document/IncognitoDocumentActivity.java View 2 chunks +2 lines, -2 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/document/IncognitoNotificationManager.java View 1 chunk +0 lines, -56 lines 0 comments Download
A + chrome/android/java/src/org/chromium/chrome/browser/incognito/IncognitoNotificationManager.java View 3 chunks +5 lines, -6 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/incognito/IncognitoNotificationService.java View 1 2 3 1 chunk +149 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tabmodel/DocumentModeAssassin.java View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tabmodel/OffTheRecordTabModel.java View 3 chunks +5 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelImpl.java View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/OffTheRecordDocumentTabModel.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java_sources.gni View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/document/DocumentModeTest.java View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
Ted C
PTAL will work on tests in parallel
4 years, 8 months ago (2016-03-31 17:25:47 UTC) #2
gone
Tests in a forthcoming CL, I suppose. lgtm https://chromiumcodereview.appspot.com/1847063003/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/incognito/IncognitoNotificationService.java File chrome/android/java/src/org/chromium/chrome/browser/incognito/IncognitoNotificationService.java (right): https://chromiumcodereview.appspot.com/1847063003/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/incognito/IncognitoNotificationService.java#newcode38 chrome/android/java/src/org/chromium/chrome/browser/incognito/IncognitoNotificationService.java:38: "com.google.android.apps.chrome.document.CLOSE_ALL_INCOGNITO"; ...
4 years, 8 months ago (2016-04-01 17:35:22 UTC) #3
Ted C
https://codereview.chromium.org/1847063003/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/incognito/IncognitoNotificationService.java File chrome/android/java/src/org/chromium/chrome/browser/incognito/IncognitoNotificationService.java (right): https://codereview.chromium.org/1847063003/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/incognito/IncognitoNotificationService.java#newcode38 chrome/android/java/src/org/chromium/chrome/browser/incognito/IncognitoNotificationService.java:38: "com.google.android.apps.chrome.document.CLOSE_ALL_INCOGNITO"; On 2016/04/01 17:35:22, dfalcantara wrote: > Assuming that ...
4 years, 8 months ago (2016-04-01 22:13:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1847063003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1847063003/40001
4 years, 8 months ago (2016-04-01 22:14:36 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/44319)
4 years, 8 months ago (2016-04-01 23:56:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1847063003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1847063003/60001
4 years, 8 months ago (2016-04-02 00:18:22 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 8 months ago (2016-04-02 01:06:12 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-02 01:07:10 UTC) #15
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/0a2547bf57fc79635eace4f935275a67b2b79d52
Cr-Commit-Position: refs/heads/master@{#384764}

Powered by Google App Engine
This is Rietveld 408576698