filter/dscache/ds.go - Issue 1846123002: Fix missing/broken ds.Stop handling in raw DS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: filter/dscache/ds.go

Issue 1846123002: Fix missing/broken ds.Stop handling in raw DS. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/gae@master

Patch Set: Better "count" helper function. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: filter/dscache/ds.go

diff --git a/filter/dscache/ds.go b/filter/dscache/ds.go

index 36a5eda685cf34d97f2f66a8ff99a0557e741abc..1ea2a3e50afdec593b26838a7128af59027df72e 100644

--- a/filter/dscache/ds.go

+++ b/filter/dscache/ds.go

@@ -119,7 +119,9 @@ func (d *dsCache) GetMulti(keys []*ds.Key, metas ds.MultiMetaGetter, cb ds.GetMu

// finally, run the callback for all of the decoded items and the errors,

// if any.

for i, dec := range p.decoded {

- cb(dec, p.lme.GetOne(i))

+ if err := cb(dec, p.lme.GetOne(i)); err != nil {

+ return err

+ }

}

return nil

« no previous file with comments | « filter/dsQueryBatch/filter.go ('k') | filter/txnBuf/query_merger.go » ('j') | no next file with comments »