filter/dsQueryBatch/filter.go - Issue 1846123002: Fix missing/broken ds.Stop handling in raw DS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: filter/dsQueryBatch/filter.go

Issue 1846123002: Fix missing/broken ds.Stop handling in raw DS. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/gae@master

Patch Set: Better "count" helper function. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: filter/dsQueryBatch/filter.go

diff --git a/filter/dsQueryBatch/filter.go b/filter/dsQueryBatch/filter.go

index e55f8eee6a9d5ff74eda0c405506fd6a4b5166b1..9b1b77ad31eeb797582b07f44b361fcffdb0895f 100644

--- a/filter/dsQueryBatch/filter.go

+++ b/filter/dsQueryBatch/filter.go

@@ -57,6 +57,7 @@ func (f *iterQueryFilter) Run(fq *ds.FinalizedQuery, cb ds.RawRunCB) error {

if cursor, err = getCursor(); err != nil {

return fmt.Errorf("failed to get cursor: %v", err)

}

+ return ds.Stop

}

return nil

})

« no previous file with comments | « filter/count/rds.go ('k') | filter/dscache/ds.go » ('j') | no next file with comments »