Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: filter/count/count.go

Issue 1846123002: Fix missing/broken ds.Stop handling in raw DS. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/gae@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | filter/count/rds.go » ('j') | filter/dsQueryBatch/context.go » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: filter/count/count.go
diff --git a/filter/count/count.go b/filter/count/count.go
index d3ff220497037071f56fb9a17492b29266e0f48a..a00321084e37614e41003eb92345e583ab301692 100644
--- a/filter/count/count.go
+++ b/filter/count/count.go
@@ -11,6 +11,8 @@ package count
import (
"fmt"
"sync/atomic"
+
+ "github.com/luci/luci-go/common/errors"
)
type counter struct {
@@ -62,3 +64,10 @@ func (e *Entry) up(errs ...error) error {
}
return err
}
+
+// upFilter calls "up", converting the filtered errors into nil. The filtering
+// does not impact the original error, which is returned directly.
+func (e *Entry) upFilter(err, filter error, filterMore ...error) error {
iannucci 2016/04/01 02:45:42 can't this just be upFilterStop? Does it ever filt
dnj 2016/04/01 21:41:05 Done.
+ e.up(errors.Filter(err, filter, filterMore...))
+ return err
+}
« no previous file with comments | « no previous file | filter/count/rds.go » ('j') | filter/dsQueryBatch/context.go » ('J')

Powered by Google App Engine
This is Rietveld 408576698