Fix missing/broken ds.Stop handling in raw DS.

filter/count/count.go

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Package count contains 'counter' filters for all the gae services. This
 // serves as a set of simple example filters, and also enables other filters
 // to test to see if certain underlying APIs are called when they should be
 // (e.g. for the datastore mcache filter, for example).
 package count
 
 import (
         "fmt"
         "sync/atomic"
+
+        "github.com/luci/luci-go/common/errors"
 )
 
 type counter struct {
         value int32
 }
 
 func (c *counter) increment() {
         atomic.AddInt32(&c.value, 1)
 }
 
@@ skipping 31 matching lines @@
         if len(errs) > 0 {
                 err = errs[0]
         }
         if err == nil {
                 e.successes.increment()
         } else {
                 e.errors.increment()
         }
         return err
 }
+
+// upFilter calls "up", converting the filtered errors into nil. The filtering
+// does not impact the original error, which is returned directly.
+func (e *Entry) upFilter(err, filter error, filterMore ...error) error {

[iannucci, 2016/04/01 02:45:42]

can't this just be upFilterStop? Does it ever filter anything else?

[dnj, 2016/04/01 21:41:05]

Done.

+        e.up(errors.Filter(err, filter, filterMore...))
+        return err
+}