Issue 18457003: Use corrected env for first sync too.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18457003: Use corrected env for first sync too. (Closed)

Created:
7 years, 5 months ago by Peter Mayo (wrong one)

Modified:
7 years, 5 months ago

Reviewers:
Peter Mayo, Isaac (away), M-A Ruel, hinoka

CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org, xusydoc+watch_chromium.org, kjellander+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/build/

Visibility:
Public.

More Reviews

Description

Use corrected env for first sync too. BUG=257423 TEST=local R=ilevy@chromium.org, maruel@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210613

Patch Set 1 #

Total comments: 1

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -6 lines)			Patch
	M	slave/run_slave.py	View		3 chunks	+13 lines, -6 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Isaac (away)

In general this lgtm, but I don't have owners here. https://codereview.chromium.org/18457003/diff/1/slave/run_slave.py File slave/run_slave.py (right): https://codereview.chromium.org/18457003/diff/1/slave/run_slave.py#newcode481 ...

7 years, 5 months ago (2013-07-04 20:56:14 UTC) #2

Peter Mayo

M-A, your power to approve is required here (cmp is backup).

7 years, 5 months ago (2013-07-04 21:15:41 UTC) #3

Peter Mayo (wrong one)

7 years, 5 months ago (2013-07-09 20:39:29 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r210613 (presubmit successful).

Expand Messages | Collapse Messages