Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 18454004: Removing highp variables from perlin noise shader (Closed)

Created:
7 years, 5 months ago by sugoi1
Modified:
7 years, 5 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Removing highp variables from perlin noise shader Variables using highp on the Adreno320 (A.K.A. Nexus 4) seem to be causing issues. I modified the shader so that all variables stay in a lower range, no longer requiring the "highp" qualifier. This may improve performance on other devices, like the xoom, where the "highp" qualifier was required. In Blink, these layout tests may require rebaselining : ./css3/filters/effect-reference-hw.html ./css3/filters/effect-reference-zoom-hw.html BUG=https://code.google.com/p/skia/issues/detail?id=1376 Committed: http://code.google.com/p/skia/source/detail?r=9903

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -26 lines) Patch
M src/effects/SkPerlinNoiseShader.cpp View 6 chunks +13 lines, -26 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sugoi
7 years, 5 months ago (2013-07-04 17:55:56 UTC) #1
Stephen White
On 2013/07/04 17:55:56, sugoi wrote: LGTM. As discussed, please list the affected Blink layout tests ...
7 years, 5 months ago (2013-07-04 18:00:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/sugoi@chromium.org/18454004/1
7 years, 5 months ago (2013-07-04 18:08:02 UTC) #3
commit-bot: I haz the power
7 years, 5 months ago (2013-07-04 18:13:06 UTC) #4
Message was sent while issue was closed.
Change committed as 9903

Powered by Google App Engine
This is Rietveld 408576698