Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issue 18444005: core/inspector: Include wtf files using "wtf/foo.h" form. (Closed)

Created:
7 years, 5 months ago by tfarina
Modified:
7 years, 5 months ago
Reviewers:
Nico, abarth-chromium
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

core/inspector: Include wtf files using "wtf/foo.h" form. Instead of including them as: \#include <wtf/foo.h> Change it to include as: \#include "wtf/foo.h" Patch generated with thakis's script: git grep -l '#include <wtf' Source/core/inspector | xargs sed -i -e 's/#include <\(wtf\/[^>]*\)>/#include "\1"/' BUG=254653 R=abarth@chromium.org,thakis@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154222

Patch Set 1 #

Patch Set 2 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -171 lines) Patch
M Source/core/inspector/CodeGeneratorInspectorStrings.py View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/inspector/CodeGeneratorInstrumentation.py View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/inspector/ContentSearchUtils.h View 1 chunk +4 lines, -5 lines 0 comments Download
M Source/core/inspector/DOMEditor.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/inspector/DOMEditor.cpp View 1 2 chunks +2 lines, -6 lines 0 comments Download
M Source/core/inspector/DOMPatchSupport.h View 1 chunk +5 lines, -6 lines 0 comments Download
M Source/core/inspector/DOMPatchSupport.cpp View 1 2 chunks +6 lines, -9 lines 0 comments Download
M Source/core/inspector/HeapGraphSerializer.h View 1 1 chunk +6 lines, -7 lines 0 comments Download
M Source/core/inspector/IdentifiersFactory.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/inspector/IdentifiersFactory.cpp View 1 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/inspector/InjectedScriptManager.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/inspector/InjectedScriptModule.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorAgent.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/inspector/InspectorApplicationCacheAgent.h View 1 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorBaseAgent.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorClient.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorConsoleAgent.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/inspector/InspectorController.h View 1 1 chunk +4 lines, -5 lines 0 comments Download
M Source/core/inspector/InspectorDatabaseAgent.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorDatabaseAgent.cpp View 1 2 chunks +1 line, -3 lines 0 comments Download
M Source/core/inspector/InspectorDatabaseResource.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/inspector/InspectorFileSystemAgent.h View 1 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorFrontendChannel.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorFrontendClient.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorHeapProfilerAgent.h View 1 1 chunk +6 lines, -7 lines 0 comments Download
M Source/core/inspector/InspectorHeapProfilerAgent.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorHistory.h View 1 chunk +3 lines, -4 lines 0 comments Download
M Source/core/inspector/InspectorIndexedDBAgent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorIndexedDBAgent.cpp View 1 2 chunks +1 line, -3 lines 0 comments Download
M Source/core/inspector/InspectorInputAgent.h View 1 1 chunk +3 lines, -5 lines 0 comments Download
M Source/core/inspector/InspectorInputAgent.cpp View 1 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorMemoryAgent.h View 1 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorOverlay.h View 1 chunk +5 lines, -6 lines 0 comments Download
M Source/core/inspector/InspectorProfilerAgent.h View 1 1 chunk +5 lines, -6 lines 0 comments Download
M Source/core/inspector/InspectorStateClient.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorWorkerAgent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/MemoryInstrumentationImpl.h View 1 1 chunk +6 lines, -7 lines 0 comments Download
M Source/core/inspector/NetworkResourcesData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/PageConsoleAgent.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/inspector/PageRuntimeAgent.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/inspector/ScriptArguments.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/inspector/ScriptBreakpoint.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/ScriptCallFrame.h View 1 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/inspector/ScriptCallStack.h View 1 1 chunk +3 lines, -4 lines 0 comments Download
M Source/core/inspector/WorkerConsoleAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/WorkerDebuggerAgent.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/inspector/WorkerInspectorController.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/inspector/WorkerInspectorController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/WorkerRuntimeAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/generate-inspector-protocol-version View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tfarina
7 years, 5 months ago (2013-07-15 03:55:53 UTC) #1
Nico
lgtm
7 years, 5 months ago (2013-07-15 04:29:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/18444005/2001
7 years, 5 months ago (2013-07-15 12:15:39 UTC) #3
commit-bot: I haz the power
7 years, 5 months ago (2013-07-15 13:01:07 UTC) #4
Message was sent while issue was closed.
Change committed as 154222

Powered by Google App Engine
This is Rietveld 408576698