Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 18435004: Build nacl_list_mappings and nosys w/ pnacl using GYP. (Closed)

Created:
7 years, 5 months ago by binji
Modified:
7 years, 5 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master
Visibility:
Public.

Description

Build nacl_list_mappings and nosys w/ pnacl using GYP. This will allow us to use GYP to build the NaCl SDK, instead of scons. BUG=none R=jvoung@chromium.org Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=11745

Patch Set 1 #

Patch Set 2 : disable gyp build on win32 bots #

Patch Set 3 : actually, put that in a different CL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/untrusted/nacl/nacl.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/untrusted/nosys/nosys.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
binji
7 years, 5 months ago (2013-07-10 16:00:31 UTC) #1
jvoung (off chromium)
lgtm
7 years, 5 months ago (2013-07-10 16:19:43 UTC) #2
binji
7 years, 5 months ago (2013-07-11 23:08:10 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r11745 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698