Issue 18419004: Remove destruction-only TearDown() methods in Drive related test.

Issue 18419004: Remove destruction-only TearDown() methods in Drive related test. (Closed)

Created:
7 years, 5 months ago by kinaba

Modified:
7 years, 5 months ago

Reviewers:
hashimoto

CC:
chromium-reviews, nkostylev+watch_chromium.org, tfarina, oshima+watch_chromium.org, tzik+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove destruction-only TearDown() methods in Drive related test. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209986

Patch Set 2 : One more thing. #

Patch Set 3 : Review fix #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -120 lines)			Patch
M	chrome/browser/chromeos/drive/change_list_processor_unittest.cc	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/drive/drive_app_registry_unittest.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/drive/drive_file_stream_reader_unittest.cc	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/drive/drive_integration_service_unittest.cc	View	1 2	1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/chromeos/drive/drive_url_request_job_unittest.cc	View		1 chunk	+0 lines, -10 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_cache_metadata_unittest.cc	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_cache_unittest.cc	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system/move_operation_unittest.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system/operation_test_base.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/drive/file_system/operation_test_base.cc	View		1 chunk	+0 lines, -11 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system/update_operation_unittest.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system_unittest.cc	View	1 2	3 chunks	+6 lines, -16 lines	0 comments	Download
M	chrome/browser/chromeos/drive/job_scheduler_unittest.cc	View		1 chunk	+0 lines, -9 lines	0 comments	Download
M	chrome/browser/chromeos/drive/local_file_reader_unittest.cc	View		2 chunks	+0 lines, -8 lines	0 comments	Download
M	chrome/browser/chromeos/drive/resource_metadata_unittest.cc	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/drive/webkit_file_stream_reader_impl_unittest.cc	View		1 chunk	+0 lines, -7 lines	0 comments	Download
M	chrome/browser/drive/drive_uploader_unittest.cc	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/google_apis/base_requests_server_unittest.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/google_apis/drive_api_requests_unittest.cc	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/google_apis/gdata_wapi_requests_unittest.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

kinaba

I'm re-read gtest document today and checked https://code.google.com/p/googletest/wiki/FAQ#Should_I_use_the_constructor/destructor_of_the_test_fixture_or_t that there's no need to TearDown if ...

7 years, 5 months ago (2013-07-03 07:50:09 UTC) #1

hashimoto

nice clean up https://codereview.chromium.org/18419004/diff/1/chrome/browser/chromeos/drive/drive_integration_service_unittest.cc File chrome/browser/chromeos/drive/drive_integration_service_unittest.cc (right): https://codereview.chromium.org/18419004/diff/1/chrome/browser/chromeos/drive/drive_integration_service_unittest.cc#newcode37 chrome/browser/chromeos/drive/drive_integration_service_unittest.cc:37: google_apis::test_util::RunBlockingPoolTask(); Isn't the dtor of BrowserThread ...

7 years, 5 months ago (2013-07-03 07:58:47 UTC) #2

kinaba

https://codereview.chromium.org/18419004/diff/1/chrome/browser/chromeos/drive/drive_integration_service_unittest.cc File chrome/browser/chromeos/drive/drive_integration_service_unittest.cc (right): https://codereview.chromium.org/18419004/diff/1/chrome/browser/chromeos/drive/drive_integration_service_unittest.cc#newcode37 chrome/browser/chromeos/drive/drive_integration_service_unittest.cc:37: google_apis::test_util::RunBlockingPoolTask(); On 2013/07/03 07:58:47, hashimoto wrote: > Isn't the ...

7 years, 5 months ago (2013-07-03 10:06:58 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/18419004/17001

7 years, 5 months ago (2013-07-03 13:13:46 UTC) #5

Message was sent while issue was closed.

Change committed as 209986

Expand Messages | Collapse Messages