Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(812)

Side by Side Diff: chrome/browser/chromeos/drive/file_system/operation_test_base.h

Issue 18419004: Remove destruction-only TearDown() methods in Drive related test. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review fix Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_CHROMEOS_DRIVE_FILE_SYSTEM_OPERATION_TEST_BASE_H_ 5 #ifndef CHROME_BROWSER_CHROMEOS_DRIVE_FILE_SYSTEM_OPERATION_TEST_BASE_H_
6 #define CHROME_BROWSER_CHROMEOS_DRIVE_FILE_SYSTEM_OPERATION_TEST_BASE_H_ 6 #define CHROME_BROWSER_CHROMEOS_DRIVE_FILE_SYSTEM_OPERATION_TEST_BASE_H_
7 7
8 #include <set> 8 #include <set>
9 9
10 #include "base/files/scoped_temp_dir.h" 10 #include "base/files/scoped_temp_dir.h"
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 private: 64 private:
65 std::set<base::FilePath> changed_paths_; 65 std::set<base::FilePath> changed_paths_;
66 std::set<std::string> upload_needed_resource_ids_; 66 std::set<std::string> upload_needed_resource_ids_;
67 }; 67 };
68 68
69 OperationTestBase(); 69 OperationTestBase();
70 virtual ~OperationTestBase(); 70 virtual ~OperationTestBase();
71 71
72 // testing::Test overrides. 72 // testing::Test overrides.
73 virtual void SetUp() OVERRIDE; 73 virtual void SetUp() OVERRIDE;
74 virtual void TearDown() OVERRIDE;
75 74
76 // Returns the path of the temporary directory for putting test files. 75 // Returns the path of the temporary directory for putting test files.
77 base::FilePath temp_dir() const { return temp_dir_.path(); } 76 base::FilePath temp_dir() const { return temp_dir_.path(); }
78 77
79 // Synchronously gets the resource entry corresponding to the path from local 78 // Synchronously gets the resource entry corresponding to the path from local
80 // ResourceMetadta. 79 // ResourceMetadta.
81 FileError GetLocalResourceEntry(const base::FilePath& path, 80 FileError GetLocalResourceEntry(const base::FilePath& path,
82 ResourceEntry* entry); 81 ResourceEntry* entry);
83 82
84 // Accessors for the components. 83 // Accessors for the components.
(...skipping 25 matching lines...) Expand all
110 scoped_ptr<internal::ResourceMetadata, test_util::DestroyHelperForTests> 109 scoped_ptr<internal::ResourceMetadata, test_util::DestroyHelperForTests>
111 metadata_; 110 metadata_;
112 scoped_ptr<FakeFreeDiskSpaceGetter> fake_free_disk_space_getter_; 111 scoped_ptr<FakeFreeDiskSpaceGetter> fake_free_disk_space_getter_;
113 scoped_ptr<internal::FileCache, test_util::DestroyHelperForTests> cache_; 112 scoped_ptr<internal::FileCache, test_util::DestroyHelperForTests> cache_;
114 }; 113 };
115 114
116 } // namespace file_system 115 } // namespace file_system
117 } // namespace drive 116 } // namespace drive
118 117
119 #endif // CHROME_BROWSER_CHROMEOS_DRIVE_FILE_SYSTEM_OPERATION_TEST_BASE_H_ 118 #endif // CHROME_BROWSER_CHROMEOS_DRIVE_FILE_SYSTEM_OPERATION_TEST_BASE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698