Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1840453003: media: Only provide necessary services in ServiceFactoryImpl (Closed)

Created:
4 years, 9 months ago by xhwang
Modified:
4 years, 9 months ago
Reviewers:
DaleCurtis
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), feature-media-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Only provide necessary services in ServiceFactoryImpl This helps avoid including code that will never be used. On Chrome for Android, this reduces the final Chrome apk binary size by 5.2kB. BUG=521731 TEST=No functionality change. Committed: https://crrev.com/cf1b00bde1ff65c94b473fd8d00f72acf495b1fc Cr-Commit-Position: refs/heads/master@{#383479}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -11 lines) Patch
M media/mojo/services/media_apptest.cc View 1 7 chunks +10 lines, -2 lines 0 comments Download
M media/mojo/services/service_factory_impl.h View 1 chunk +9 lines, -4 lines 0 comments Download
M media/mojo/services/service_factory_impl.cc View 7 chunks +24 lines, -5 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
xhwang
PTAL https://chromiumcodereview.appspot.com/1840453003/diff/1/media/mojo/services/service_factory_impl.h File media/mojo/services/service_factory_impl.h (right): https://chromiumcodereview.appspot.com/1840453003/diff/1/media/mojo/services/service_factory_impl.h#newcode62 media/mojo/services/service_factory_impl.h:62: MojoCdmServiceContext cdm_service_context_; In theory I can ifdef this ...
4 years, 9 months ago (2016-03-25 22:27:12 UTC) #5
DaleCurtis
lgtm https://chromiumcodereview.appspot.com/1840453003/diff/1/media/mojo/services/service_factory_impl.h File media/mojo/services/service_factory_impl.h (right): https://chromiumcodereview.appspot.com/1840453003/diff/1/media/mojo/services/service_factory_impl.h#newcode62 media/mojo/services/service_factory_impl.h:62: MojoCdmServiceContext cdm_service_context_; On 2016/03/25 at 22:27:12, xhwang wrote: ...
4 years, 9 months ago (2016-03-25 22:29:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1840453003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1840453003/1
4 years, 9 months ago (2016-03-25 22:49:31 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/202343)
4 years, 9 months ago (2016-03-26 00:55:26 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1840453003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1840453003/20001
4 years, 9 months ago (2016-03-28 04:28:32 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-28 04:33:40 UTC) #15
commit-bot: I haz the power
4 years, 9 months ago (2016-03-28 04:34:42 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cf1b00bde1ff65c94b473fd8d00f72acf495b1fc
Cr-Commit-Position: refs/heads/master@{#383479}

Powered by Google App Engine
This is Rietveld 408576698