media: Only provide necessary services in ServiceFactoryImpl

media: Only provide necessary services in ServiceFactoryImpl

This helps avoid including code that will never be used. On Chrome for
Android, this reduces the final Chrome apk binary size by 5.2kB.

BUG=521731
TEST=No functionality change.

Committed: https://crrev.com/cf1b00bde1ff65c94b473fd8d00f72acf495b1fc
Cr-Commit-Position: refs/heads/master@{#383479}

[xhwang, 2016-03-25 22:19:20]

Description was changed from

==========
media: Only provide necessary services in ServiceFactoryImpl.

This helps avoid including code that will never be used. On Chrome for
Android, this reduces the final Chrome apk binary size by 11.5kB.

BUG=521731
TEST=No functionality change.
==========

to

==========
media: Only provide necessary services in ServiceFactoryImpl

This helps avoid including code that will never be used. On Chrome for
Android, this reduces the final Chrome apk binary size by 11.5kB.

BUG=521731
TEST=No functionality change.
==========

[xhwang, 2016-03-25 22:20:58]

Description was changed from

==========
media: Only provide necessary services in ServiceFactoryImpl

This helps avoid including code that will never be used. On Chrome for
Android, this reduces the final Chrome apk binary size by 11.5kB.

BUG=521731
TEST=No functionality change.
==========

to

==========
media: Only provide necessary services in ServiceFactoryImpl

This helps avoid including code that will never be used. On Chrome for
Android, this reduces the final Chrome apk binary size by ???kB.

BUG=521731
TEST=No functionality change.
==========

[xhwang, 2016-03-25 22:24:46]

Description was changed from

==========
media: Only provide necessary services in ServiceFactoryImpl

This helps avoid including code that will never be used. On Chrome for
Android, this reduces the final Chrome apk binary size by ???kB.

BUG=521731
TEST=No functionality change.
==========

to

==========
media: Only provide necessary services in ServiceFactoryImpl

This helps avoid including code that will never be used. On Chrome for
Android, this reduces the final Chrome apk binary size by 5.2kB.

BUG=521731
TEST=No functionality change.
==========

[xhwang, 2016-03-25 22:27:12]

xhwang@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[xhwang, 2016-03-25 22:27:12]

PTAL

https://chromiumcodereview.appspot.com/1840453003/diff/1/media/mojo/services/...
File media/mojo/services/service_factory_impl.h (right):

https://chromiumcodereview.appspot.com/1840453003/diff/1/media/mojo/services/...
media/mojo/services/service_factory_impl.h:62: MojoCdmServiceContext
cdm_service_context_;
In theory I can ifdef this as well, but it'll be more complicated. And we do
need it by default on Android. So maybe not worth the effort.

[DaleCurtis, 2016-03-25 22:29:13]

lgtm

https://chromiumcodereview.appspot.com/1840453003/diff/1/media/mojo/services/...
File media/mojo/services/service_factory_impl.h (right):

https://chromiumcodereview.appspot.com/1840453003/diff/1/media/mojo/services/...
media/mojo/services/service_factory_impl.h:62: MojoCdmServiceContext
cdm_service_context_;
On 2016/03/25 at 22:27:12, xhwang wrote:
> In theory I can ifdef this as well, but it'll be more complicated. And we do
need it by default on Android. So maybe not worth the effort.

Shouldn't matter if it's used anyways then.

[xhwang, 2016-03-25 22:49:13]

The CQ bit was checked by xhwang@chromium.org

[commit-bot: I haz the power, 2016-03-25 22:49:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1840453003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1840453003/1

[commit-bot: I haz the power, 2016-03-26 00:55:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-26 00:55:26]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[xhwang, 2016-03-28 04:28:21]

The CQ bit was checked by xhwang@chromium.org

[xhwang, 2016-03-28 04:28:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
dalecurtis@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1840453003/#ps20001
(title: "fix test")

[commit-bot: I haz the power, 2016-03-28 04:28:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1840453003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1840453003/20001

[commit-bot: I haz the power, 2016-03-28 04:33:39]

Description was changed from

==========
media: Only provide necessary services in ServiceFactoryImpl

This helps avoid including code that will never be used. On Chrome for
Android, this reduces the final Chrome apk binary size by 5.2kB.

BUG=521731
TEST=No functionality change.
==========

to

==========
media: Only provide necessary services in ServiceFactoryImpl

This helps avoid including code that will never be used. On Chrome for
Android, this reduces the final Chrome apk binary size by 5.2kB.

BUG=521731
TEST=No functionality change.
==========

[commit-bot: I haz the power, 2016-03-28 04:33:40]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-28 04:34:41]

Description was changed from

==========
media: Only provide necessary services in ServiceFactoryImpl

This helps avoid including code that will never be used. On Chrome for
Android, this reduces the final Chrome apk binary size by 5.2kB.

BUG=521731
TEST=No functionality change.
==========

to

==========
media: Only provide necessary services in ServiceFactoryImpl

This helps avoid including code that will never be used. On Chrome for
Android, this reduces the final Chrome apk binary size by 5.2kB.

BUG=521731
TEST=No functionality change.

Committed: https://crrev.com/cf1b00bde1ff65c94b473fd8d00f72acf495b1fc
Cr-Commit-Position: refs/heads/master@{#383479}
==========

[commit-bot: I haz the power, 2016-03-28 04:34:42]

Patchset 2 (id:??) landed as
https://crrev.com/cf1b00bde1ff65c94b473fd8d00f72acf495b1fc
Cr-Commit-Position: refs/heads/master@{#383479}