Remove IDBNotFoundError ExceptionCode

Source/bindings/v8/custom/V8NodeCustom.cpp

Index: Source/bindings/v8/custom/V8NodeCustom.cpp
diff --git a/Source/bindings/v8/custom/V8NodeCustom.cpp b/Source/bindings/v8/custom/V8NodeCustom.cpp
index 447fb776fd4be5faa6c93c18982a0b9fbecb79ff..73246e47cd1eb0dc0824ef5ccb05d134c5c2ca8e 100644
--- a/Source/bindings/v8/custom/V8NodeCustom.cpp
+++ b/Source/bindings/v8/custom/V8NodeCustom.cpp
@@ -46,6 +46,7 @@
 #include "V8SVGElement.h"
 #include "V8ShadowRoot.h"
 #include "V8Text.h"
+#include "bindings/v8/ExceptionState.h"
 #include "bindings/v8/V8AbstractEventListener.h"
 #include "bindings/v8/V8Binding.h"
 #include "bindings/v8/V8EventListener.h"
@@ -65,14 +66,13 @@ void V8Node::insertBeforeMethodCustom(const v8::FunctionCallbackInfo<v8::Value>&
 
     CustomElementCallbackDispatcher::CallbackDeliveryScope deliveryScope;
 
-    ExceptionCode ec = 0;
+    ExceptionState es(args.GetIsolate());

[Mike West, 2013/07/10 09:40:30]

This all looks perfectly reasonable, but doesn't seem related to the CL's stated
purpose (IDB changes). Would you mind splitting the Node changes out into a
separate patch (or updating the description with relevant detail)?

[arv (Not doing code reviews), 2013/07/10 15:37:24]

Done.

     Node* newChild = V8Node::HasInstance(args[0], args.GetIsolate(), worldType(args.GetIsolate())) ? V8Node::toNative(v8::Handle<v8::Object>::Cast(args[0])) : 0;
     Node* refChild = V8Node::HasInstance(args[1], args.GetIsolate(), worldType(args.GetIsolate())) ? V8Node::toNative(v8::Handle<v8::Object>::Cast(args[1])) : 0;
-    imp->insertBefore(newChild, refChild, ec, AttachLazily);
-    if (ec)
-        setDOMException(ec, args.GetIsolate());
-    else
-        v8SetReturnValue(args, args[0]);
+    imp->insertBefore(newChild, refChild, es, AttachLazily);
+    if (es.throwIfNeeded())
+        return;
+    v8SetReturnValue(args, args[0]);
 }
 
 // This function is customized to take advantage of the optional 4th argument: AttachBehavior
@@ -83,14 +83,13 @@ void V8Node::replaceChildMethodCustom(const v8::FunctionCallbackInfo<v8::Value>&
 
     CustomElementCallbackDispatcher::CallbackDeliveryScope deliveryScope;
 
-    ExceptionCode ec = 0;
+    ExceptionState es(args.GetIsolate());
     Node* newChild = V8Node::HasInstance(args[0], args.GetIsolate(), worldType(args.GetIsolate())) ? V8Node::toNative(v8::Handle<v8::Object>::Cast(args[0])) : 0;
     Node* oldChild = V8Node::HasInstance(args[1], args.GetIsolate(), worldType(args.GetIsolate())) ? V8Node::toNative(v8::Handle<v8::Object>::Cast(args[1])) : 0;
-    imp->replaceChild(newChild, oldChild, ec, AttachLazily);
-    if (ec)
-        setDOMException(ec, args.GetIsolate());
-    else
-        v8SetReturnValue(args, args[1]);
+    imp->replaceChild(newChild, oldChild, es, AttachLazily);
+    if (es.throwIfNeeded())
+        return;
+    v8SetReturnValue(args, args[1]);
 }
 
 void V8Node::removeChildMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& args)
@@ -100,13 +99,12 @@ void V8Node::removeChildMethodCustom(const v8::FunctionCallbackInfo<v8::Value>&
 
     CustomElementCallbackDispatcher::CallbackDeliveryScope deliveryScope;
 
-    ExceptionCode ec = 0;
+    ExceptionState es(args.GetIsolate());
     Node* oldChild = V8Node::HasInstance(args[0], args.GetIsolate(), worldType(args.GetIsolate())) ? V8Node::toNative(v8::Handle<v8::Object>::Cast(args[0])) : 0;
-    imp->removeChild(oldChild, ec);
-    if (ec)
-        setDOMException(ec, args.GetIsolate());
-    else
-        v8SetReturnValue(args, args[0]);
+    imp->removeChild(oldChild, es);
+    if (es.throwIfNeeded())
+        return;
+    v8SetReturnValue(args, args[0]);
 }
 
 // This function is customized to take advantage of the optional 4th argument: AttachBehavior
@@ -117,13 +115,12 @@ void V8Node::appendChildMethodCustom(const v8::FunctionCallbackInfo<v8::Value>&
 
     CustomElementCallbackDispatcher::CallbackDeliveryScope deliveryScope;
 
-    ExceptionCode ec = 0;
+    ExceptionState es(args.GetIsolate());
     Node* newChild = V8Node::HasInstance(args[0], args.GetIsolate(), worldType(args.GetIsolate())) ? V8Node::toNative(v8::Handle<v8::Object>::Cast(args[0])) : 0;
-    imp->appendChild(newChild, ec, AttachLazily);
-    if (ec)
-        setDOMException(ec, args.GetIsolate());
-    else
-        v8SetReturnValue(args, args[0]);
+    imp->appendChild(newChild, es, AttachLazily);
+    if (es.throwIfNeeded())
+        return;
+    v8SetReturnValue(args, args[0]);
 }
 
 v8::Handle<v8::Object> wrap(Node* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)