Remove IDBNotFoundError ExceptionCode

Source/bindings/v8/custom/V8NodeCustom.cpp

 /*
  * Copyright (C) 2007-2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 28 matching lines @@
 #include "V8DocumentType.h"
 #include "V8Element.h"
 #include "V8Entity.h"
 #include "V8HTMLElement.h"
 #include "V8Node.h"
 #include "V8Notation.h"
 #include "V8ProcessingInstruction.h"
 #include "V8SVGElement.h"
 #include "V8ShadowRoot.h"
 #include "V8Text.h"
+#include "bindings/v8/ExceptionState.h"
 #include "bindings/v8/V8AbstractEventListener.h"
 #include "bindings/v8/V8Binding.h"
 #include "bindings/v8/V8EventListener.h"
 #include "core/dom/CustomElementCallbackDispatcher.h"
 #include "core/dom/Document.h"
 #include "core/dom/EventListener.h"
 #include "core/dom/shadow/ShadowRoot.h"
 #include "wtf/RefPtr.h"
 
 namespace WebCore {
 
 // This function is customized to take advantage of the optional 4th argument: AttachBehavior
 void V8Node::insertBeforeMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& args)
 {
     v8::Handle<v8::Object> holder = args.Holder();
     Node* imp = V8Node::toNative(holder);
 
     CustomElementCallbackDispatcher::CallbackDeliveryScope deliveryScope;
 
-    ExceptionCode ec = 0;
+    ExceptionState es(args.GetIsolate());

[Mike West, 2013/07/10 09:40:30]

This all looks perfectly reasonable, but doesn't seem related to the CL's stated
purpose (IDB changes). Would you mind splitting the Node changes out into a
separate patch (or updating the description with relevant detail)?

[arv (Not doing code reviews), 2013/07/10 15:37:24]

Done.

     Node* newChild = V8Node::HasInstance(args[0], args.GetIsolate(), worldType(args.GetIsolate())) ? V8Node::toNative(v8::Handle<v8::Object>::Cast(args[0])) : 0;
     Node* refChild = V8Node::HasInstance(args[1], args.GetIsolate(), worldType(args.GetIsolate())) ? V8Node::toNative(v8::Handle<v8::Object>::Cast(args[1])) : 0;
-    imp->insertBefore(newChild, refChild, ec, AttachLazily);
-    if (ec)
-        setDOMException(ec, args.GetIsolate());
-    else
-        v8SetReturnValue(args, args[0]);
+    imp->insertBefore(newChild, refChild, es, AttachLazily);
+    if (es.throwIfNeeded())
+        return;
+    v8SetReturnValue(args, args[0]);
 }
 
 // This function is customized to take advantage of the optional 4th argument: AttachBehavior
 void V8Node::replaceChildMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& args)
 {
     v8::Handle<v8::Object> holder = args.Holder();
     Node* imp = V8Node::toNative(holder);
 
     CustomElementCallbackDispatcher::CallbackDeliveryScope deliveryScope;
 
-    ExceptionCode ec = 0;
+    ExceptionState es(args.GetIsolate());
     Node* newChild = V8Node::HasInstance(args[0], args.GetIsolate(), worldType(args.GetIsolate())) ? V8Node::toNative(v8::Handle<v8::Object>::Cast(args[0])) : 0;
     Node* oldChild = V8Node::HasInstance(args[1], args.GetIsolate(), worldType(args.GetIsolate())) ? V8Node::toNative(v8::Handle<v8::Object>::Cast(args[1])) : 0;
-    imp->replaceChild(newChild, oldChild, ec, AttachLazily);
-    if (ec)
-        setDOMException(ec, args.GetIsolate());
-    else
-        v8SetReturnValue(args, args[1]);
+    imp->replaceChild(newChild, oldChild, es, AttachLazily);
+    if (es.throwIfNeeded())
+        return;
+    v8SetReturnValue(args, args[1]);
 }
 
 void V8Node::removeChildMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& args)
 {
     v8::Handle<v8::Object> holder = args.Holder();
     Node* imp = V8Node::toNative(holder);
 
     CustomElementCallbackDispatcher::CallbackDeliveryScope deliveryScope;
 
-    ExceptionCode ec = 0;
+    ExceptionState es(args.GetIsolate());
     Node* oldChild = V8Node::HasInstance(args[0], args.GetIsolate(), worldType(args.GetIsolate())) ? V8Node::toNative(v8::Handle<v8::Object>::Cast(args[0])) : 0;
-    imp->removeChild(oldChild, ec);
-    if (ec)
-        setDOMException(ec, args.GetIsolate());
-    else
-        v8SetReturnValue(args, args[0]);
+    imp->removeChild(oldChild, es);
+    if (es.throwIfNeeded())
+        return;
+    v8SetReturnValue(args, args[0]);
 }
 
 // This function is customized to take advantage of the optional 4th argument: AttachBehavior
 void V8Node::appendChildMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& args)
 {
     v8::Handle<v8::Object> holder = args.Holder();
     Node* imp = V8Node::toNative(holder);
 
     CustomElementCallbackDispatcher::CallbackDeliveryScope deliveryScope;
 
-    ExceptionCode ec = 0;
+    ExceptionState es(args.GetIsolate());
     Node* newChild = V8Node::HasInstance(args[0], args.GetIsolate(), worldType(args.GetIsolate())) ? V8Node::toNative(v8::Handle<v8::Object>::Cast(args[0])) : 0;
-    imp->appendChild(newChild, ec, AttachLazily);
-    if (ec)
-        setDOMException(ec, args.GetIsolate());
-    else
-        v8SetReturnValue(args, args[0]);
+    imp->appendChild(newChild, es, AttachLazily);
+    if (es.throwIfNeeded())
+        return;
+    v8SetReturnValue(args, args[0]);
 }
 
 v8::Handle<v8::Object> wrap(Node* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
 {
     ASSERT(impl);
     switch (impl->nodeType()) {
     case Node::ELEMENT_NODE:
         // For performance reasons, this is inlined from V8Element::wrap and must remain in sync.
         if (impl->isHTMLElement())
             return wrap(toHTMLElement(impl), creationContext, isolate);
@@ skipping 21 matching lines @@
             return wrap(toShadowRoot(impl), creationContext, isolate);
         return wrap(static_cast<DocumentFragment*>(impl), creationContext, isolate);
     case Node::NOTATION_NODE:
         return wrap(static_cast<Notation*>(impl), creationContext, isolate);
     default:
         break; // ENTITY_REFERENCE_NODE or XPATH_NAMESPACE_NODE
     }
     return V8Node::createWrapper(impl, creationContext, isolate);
 }
 } // namespace WebCore