Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 18396002: Initialize all OmniboxViewMac member variables (Closed)

Created:
7 years, 5 months ago by sail
Modified:
7 years, 5 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, James Su
Visibility:
Public.

Description

Initialize all OmniboxViewMac member variables Some OmniboxViewMac member variables weren't being initialized in the constructor. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209544

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sail
Noticed this issue while investigating bug 251471.
7 years, 5 months ago (2013-07-01 21:46:48 UTC) #1
Robert Sesek
lgtm
7 years, 5 months ago (2013-07-01 21:50:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/18396002/1
7 years, 5 months ago (2013-07-01 21:52:21 UTC) #3
commit-bot: I haz the power
7 years, 5 months ago (2013-07-01 23:46:30 UTC) #4
Message was sent while issue was closed.
Change committed as 209544

Powered by Google App Engine
This is Rietveld 408576698