Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(16)

Issue 1832093003: Fix MB and running mash browser_tests under swarming (Closed)

Created:
3 years, 8 months ago by Dirk Pranke
Modified:
3 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix MB and running browser_tests under mash Unfortunately, the way to run a test on the bots can vary between swarming and running directly; to run under swarming, you need to ensure that the files needed to run the test and the command line is embedded in the BUILD files (and gn_isolate_map) themselves, rather than being able to specify them in the //testing/buildbot files. This patch changes the way we were attempting to run tests for mash on the chromium.mojo linux bot, so that the tests are run under swarming. In addition, this patch fixes a bunch of bugs uncovered when trying to reproduce issues locally, and improves the help documentation significantly. R=sky@chromium.org BUG= Committed: https://crrev.com/030d7a6d83781190237c66c8f0317f24f356e428 Cr-Commit-Position: refs/heads/master@{#383457}

Patch Set 1 : patch for review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -21 lines) Patch
M chrome/test/BUILD.gn View 1 chunk +19 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.mojo.json View 1 chunk +6 lines, -4 lines 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 chunk +7 lines, -0 lines 0 comments Download
M tools/mb/mb.py View 8 chunks +53 lines, -17 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Dirk Pranke
3 years, 8 months ago (2016-03-26 03:02:24 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1832093003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1832093003/20001
3 years, 8 months ago (2016-03-26 03:02:56 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 8 months ago (2016-03-26 04:19:37 UTC) #7
sky
LGTM - thanks!
3 years, 8 months ago (2016-03-26 15:17:48 UTC) #8
Dirk Pranke
3 years, 8 months ago (2016-03-26 17:19:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1832093003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1832093003/20001
3 years, 8 months ago (2016-03-26 17:19:43 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:20001)
3 years, 8 months ago (2016-03-26 17:24:04 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2016-03-26 17:25:23 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/030d7a6d83781190237c66c8f0317f24f356e428
Cr-Commit-Position: refs/heads/master@{#383457}

Powered by Google App Engine
This is Rietveld 408576698