Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 18318002: DateComponents shouldn't use bloatedCharacters (Closed)

Created:
7 years, 5 months ago by abarth-chromium
Modified:
7 years, 5 months ago
Reviewers:
eseidel
CC:
blink-reviews, jeez, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org
Visibility:
Public.

Description

DateComponents shouldn't use bloatedCharacters This code was already index-based, so converting it to use String instead of UChar* was easy. R=eseidel BUG=254708 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153325

Patch Set 1 #

Patch Set 2 : fix build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -83 lines) Patch
M Source/WebKit/chromium/tests/LocaleMacTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/BaseDateAndTimeInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/BaseDateAndTimeInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/BaseMultipleFieldsDateAndTimeInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/DateInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/DateInputType.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/DateTimeLocalInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/DateTimeLocalInputType.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/MonthInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/MonthInputType.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/TimeInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/TimeInputType.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/WeekInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/WeekInputType.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/platform/DateComponents.h View 2 chunks +8 lines, -8 lines 0 comments Download
M Source/core/platform/DateComponents.cpp View 13 chunks +50 lines, -55 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
abarth-chromium
7 years, 5 months ago (2013-07-01 06:20:59 UTC) #1
eseidel
lgtm sooooo much nicer.
7 years, 5 months ago (2013-07-01 06:24:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/18318002/1
7 years, 5 months ago (2013-07-01 06:24:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/18318002/6001
7 years, 5 months ago (2013-07-01 06:31:39 UTC) #4
commit-bot: I haz the power
7 years, 5 months ago (2013-07-01 07:39:51 UTC) #5
Message was sent while issue was closed.
Change committed as 153325

Powered by Google App Engine
This is Rietveld 408576698