Source/core/html/BaseDateAndTimeInputType.h - Issue 18318002: DateComponents shouldn't use bloatedCharacters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/BaseDateAndTimeInputType.h

Issue 18318002: DateComponents shouldn't use bloatedCharacters (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: fix build Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/BaseDateAndTimeInputType.h

diff --git a/Source/core/html/BaseDateAndTimeInputType.h b/Source/core/html/BaseDateAndTimeInputType.h

index 69447ac5774c417ad2c004ab01a9d29c95a36613..5416764fb333121bd61a19e5006bb3f418abe124 100644

--- a/Source/core/html/BaseDateAndTimeInputType.h

+++ b/Source/core/html/BaseDateAndTimeInputType.h

@@ -49,7 +49,7 @@ protected:

virtual String visibleValue() const OVERRIDE;

private:

- virtual bool parseToDateComponentsInternal(const UChar*, unsigned length, DateComponents*) const = 0;

+ virtual bool parseToDateComponentsInternal(const String&, DateComponents*) const = 0;

virtual DateComponents::Type dateType() const = 0;

virtual double valueAsDate() const OVERRIDE;

virtual void setValueAsDate(double, ExceptionCode&) const OVERRIDE;