Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 18316003: Revert "Use V8 implementation of ArrayBuffer in Blink." (Closed)

Created:
7 years, 5 months ago by caseq
Modified:
7 years, 5 months ago
CC:
blink-reviews, Nils Barth (inactive), loislo+blink_chromium.org, jsbell+bindings_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, Rik, adamk+blink_chromium.org, haraken, Nate Chapin, jeez, do-not-use
Visibility:
Public.

Description

Revert "Use V8 implementation of ArrayBuffer in Blink." This reverts commit b0d6ba9c280e507fb5f853f495a72d76327a3bcd. (broke 3 browser_tests: PostData2,TransferFailure,ZeroLengthTransfer) TBR=dslomov@chromium.org,kbr@chromium.org,jochen@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153335

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -279 lines) Patch
M LayoutTests/fast/canvas/webgl/script-tests/array-message-passing.js View 1 chunk +1 line, -6 lines 0 comments Download
M Source/WebKit/chromium/src/WebArrayBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebKit/chromium/src/WebBindings.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/WebKit/chromium/src/WebKit.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/bindings/scripts/CodeGeneratorV8.pm View 8 chunks +12 lines, -16 lines 0 comments Download
M Source/bindings/tests/results/V8TestOverloadedConstructors.cpp View 3 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/SerializedScriptValue.cpp View 8 chunks +12 lines, -22 lines 0 comments Download
M Source/bindings/v8/V8Binding.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/bindings/v8/V8Binding.cpp View 2 chunks +0 lines, -23 lines 0 comments Download
M Source/bindings/v8/V8Utilities.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8ArrayBufferCustom.h View 2 chunks +1 line, -97 lines 0 comments Download
M Source/bindings/v8/custom/V8ArrayBufferCustom.cpp View 2 chunks +35 lines, -57 lines 0 comments Download
M Source/bindings/v8/custom/V8ArrayBufferViewCustom.h View 1 chunk +4 lines, -3 lines 0 comments Download
M Source/bindings/v8/custom/V8AudioContextCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8BlobCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8FileReaderCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8MessageEventCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8XMLHttpRequestCustom.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/core.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A + Source/core/html/canvas/ArrayBuffer.idl View 1 chunk +5 lines, -6 lines 0 comments Download
M Source/wtf/ArrayBuffer.h View 3 chunks +2 lines, -3 lines 0 comments Download
M Source/wtf/ArrayBuffer.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/wtf/ArrayBufferContents.h View 2 chunks +0 lines, -8 lines 0 comments Download
M Source/wtf/ArrayBufferContents.cpp View 2 chunks +10 lines, -21 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
caseq
7 years, 5 months ago (2013-07-01 09:51:42 UTC) #1
Message was sent while issue was closed. 
Committed patchset #1 manually as r153335 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698