Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Unified Diff: net/url_request/url_request_throttler_manager.h

Issue 18261003: Cleaning up TODO(joi) entries in //net. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge LKGR. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/backoff_entry.cc ('k') | net/url_request/url_request_throttler_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_throttler_manager.h
diff --git a/net/url_request/url_request_throttler_manager.h b/net/url_request/url_request_throttler_manager.h
index 31d28ef3e77084d24287a9296d62ca4cef8a8c4b..ee4f9e9d84db17e6c2a161becc86f6f46c936452 100644
--- a/net/url_request/url_request_throttler_manager.h
+++ b/net/url_request/url_request_throttler_manager.h
@@ -63,12 +63,6 @@ class NET_EXPORT URLRequestThrottlerManager
// It is only used by unit tests.
void EraseEntryForTests(const GURL& url);
- // Turns threading model verification on or off. Any code that correctly
- // uses the network stack should preferably call this function to enable
- // verification of correct adherence to the network stack threading model.
- void set_enable_thread_checks(bool enable);
- bool enable_thread_checks() const;
-
// Whether throttling is enabled or not.
void set_enforce_throttling(bool enforce);
bool enforce_throttling();
@@ -140,14 +134,6 @@ class NET_EXPORT URLRequestThrottlerManager
// Valid after construction.
GURL::Replacements url_id_replacements_;
- // Certain tests do not obey the net component's threading policy, so we
- // keep track of whether we're being used by tests, and turn off certain
- // checks.
- //
- // TODO(joi): See if we can fix the offending unit tests and remove this
- // workaround.
- bool enable_thread_checks_;
-
// Initially false, switches to true once we have logged because of back-off
// being disabled for localhost.
bool logged_for_localhost_disabled_;
« no previous file with comments | « net/base/backoff_entry.cc ('k') | net/url_request/url_request_throttler_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698